Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update library versions #17

Merged
merged 1 commit into from
Jan 8, 2021
Merged

Conversation

amotl
Copy link
Member

@amotl amotl commented Jan 8, 2021

Hi Clemens and Andreas,

this uses the most recent versions of the U8g2 and ESP32Servo libraries.

Both libraries are well maintained by their respective authors and maintainers, so we should use them in favour of outdated libraries which are no longer maintained.

A little adjustment has been made to one #include statement. The updated library header file is now called ESP32Servo.h instead of ESP32_Servo.h.

This also corresponds with 8e605aa by @andreash-esp.

With kind regards,
Andreas.

@amotl
Copy link
Member Author

amotl commented Jan 8, 2021

You have to also adjust the servo defaults.

Thanks. I will amend this patch accordingly.

@amotl amotl mentioned this pull request Jan 8, 2021
@ClemensGruber
Copy link
Collaborator

Ich möchte im code nicht auf platformio als Bibliotheks-Quelle hinweisen, wenn die Bibliothek über die Arduino-IDE installiert werden kann. Wir haben u.a. auch die ESP32-Servo-Bibliothek gewechselt, damit Leute die einfach(er) über die Arduino-IDE einbinden können.

Wenn jemand platformio verwendet sind die Dinge in platformio.ini hinterlegt und man muss sich eh nicht kümmern, daher finde ich die Änderung der Kommentare hier kontraproduktiv.

#include <U8g2lib.h> /* aus dem Bibliotheksverwalter */
vs
#include <U8g2lib.h> /* https://platformio.org/lib/show/942/U8g2 */

@amotl
Copy link
Member Author

amotl commented Jan 8, 2021

Ich möchte im code nicht auf PlatformIO als Bibliotheks-Quelle hinweisen.

Dann nehme ich das wieder zurueck.

This uses the most recent versions of the U8g2 and ESP32Servo libraries.

Both libraries are well maintained by their respective authors and
maintainers, so we should use them in favour of outdated libraries
which are no longer maintained.

A little adjustment has been made to one #include statement. The
updated library header file is now called "ESP32Servo.h" instead
of "ESP32_Servo.h".

Also, the servo default settings for the non-"SERVO_ERWEITERT" branch
have been adjusted.
@amotl
Copy link
Member Author

amotl commented Jan 8, 2021

Hi Clemens,

ich habe den Patch ensprechend angepasst.

Viele Gruesse,
Andreas.

@ClemensGruber ClemensGruber merged commit 3c72af8 into hiveeyes:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants