-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPIC: Plot refactor metadata #493
Open
M-Kusumgar
wants to merge
115
commits into
main
Choose a base branch
from
tmp-epic-plot-cleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #493 +/- ##
==========================================
+ Coverage 98.49% 98.53% +0.03%
==========================================
Files 29 29
Lines 2389 2449 +60
==========================================
+ Hits 2353 2413 +60
Misses 36 36 ☔ View full report in Codecov by Sentry. |
2 tasks
This is required because there is a bug in r-system-requirements which is causing libssh2 to be installed as the system dependency of ssh package. When in fact it needs libssh.
Update comparison metadata to new format
Add metadata for table
Comparison metadata
Metadata defaults
Rename ChoroplethIndicatorMetadata to IndicatorMetadata
Tmp epic plot cleanup input
These are failing for annoying to diagnose reasons, but we don't actually need this code to run on mac.
Remove old endpoints, add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be the temp branch for the plot cleanup and we can just freely push what we want to this whenever we need it during the plot cleanup epic, for reference, the type of metadata is: