Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mrc-4856: EPIC plot refactor #933

Merged
merged 281 commits into from
Sep 17, 2024
Merged

mrc-4856: EPIC plot refactor #933

merged 281 commits into from
Sep 17, 2024

Conversation

r-ash
Copy link
Collaborator

@r-ash r-ash commented Feb 8, 2024 •
edited
Loading

Description

This is the base for the epic branch for the plot cleanup. You should be able to click through hint and download results without seeing any plots.

The current plan is to just start from scratch using the previous code as inspiration. We will raise PRs into this branch of tasks outlined in https://miro.com/app/board/uXjVNEVS-bw=/ and all components should be done in composition api style.

Note: Tests may not fully pass and build will finish with some errors potentially. Just use npm run serve if this happens, it will just build with errors/warnings.

We're building this with hintr branch hivtools/hintr#493, get that merged before we merge this PR

Type of version change

Minor

Checklist

  • I have incremented version number, or version needs no increment
  • The build passed successfully, or failed because of ADR tests

M-Kusumgar and others added 26 commits February 14, 2024 15:48
@M-Kusumgar
add error handling to plotSelections state + write function to send f…
e64fb11 
…etch payload to backend
@M-Kusumgar
Merge branch 'mrc-4857' of github.com:mrc-ide/hint into mrc-5056
b8e9b9c
@M-Kusumgar
add data state + fetch values
07e6e84
@r-ash
Add choropleth component with new filters
8831e65
@M-Kusumgar
fix outputPlot dilemma
33c60a9
@M-Kusumgar
remove console.logs
3e0fd55
@M-Kusumgar
remove console.log
3d2c2e0
@r-ash
Merge branch 'mrc-5056' into mrc-5067
0cc064c
@r-ash
Add WIP choropleth back in
3d7a65f
@r-ash
WIP add choropleth back in
1f177dc
@r-ash
Add WIP
538bcbb
@r-ash
Get filter scales working
2988b55
@r-ash
Get version working with getters
830b221
@r-ash
WIP using watchers
ad0ba22
@r-ash
Add choropleth back in using common filters
ef8a2e3
@r-ash
Use setup script
da28280
@r-ash
Add bubble plot
8e1760e
@r-ash
Debounce map updates, keep entire map drawn in bubble plot all the time
560c082
@r-ash
Tidy up exported functions
ed5cc48
@r-ash
Fix issue where bubbles not updating when scale changes
66f0350
@r-ash
Remove emits in favour of watching on state, improve styling
9b81bb8
@M-Kusumgar
Merge pull request #934 from mrc-ide/mrc-5039
aee9420 
Mrc 5039 new state for plot selection + commit defaults into state
@M-Kusumgar
Merge pull request #935 from mrc-ide/mrc-5055
a718357 
mrc-5055: Add filters and plot controls UI
@r-ash
Merge pull request #936 from mrc-ide/mrc-5065
ea4dbad 
Mrc 5065 hook up state to filters and plot control UI
@r-ash
Merge pull request #952 from mrc-ide/mrc-5056
f8254f2 
Mrc 5056
@r-ash
Merge pull request #943 from mrc-ide/mrc-5067
6eaeef6 
mrc-5067: Add choropleth plot
@r-ash r-ash mentioned this pull request Apr 9, 2024
Closed
2 tasks
M-Kusumgar and others added 24 commits September 12, 2024 14:47
@M-Kusumgar
show model output once plot metadata is fetched
36fc9f9
@M-Kusumgar
fix test
337e7f3
@M-Kusumgar
revert playwright debugging on ci
3ced4fc
@M-Kusumgar
clean up diff
31056c0
@M-Kusumgar
review comment: change function name
6ce2fc2
@r-ash
Merge pull request #997 from mrc-ide/backwards-compatibility-plot-ref…
0ec2f23 
…actor

make state backwards compatible
@r-ash
Add download time series button back in
5d213a4
@r-ash
Remove unnecessary hasTimeSeries flag
39815d3
@r-ash
Merge pull request #998 from mrc-ide/add-time-series-download
58af632 
Add download time series button back in
@r-ash
Do all dependabot updates and fix issues
3e2a2f4
@r-ash
Update end to end screenshots, make tests more robust
42f9cb9
@r-ash
Update docs
7179828
@r-ash
Update to use new argument name for suppressing menu buttons
b868ab4
@r-ash
Install audit fixes
423c20b
@r-ash
Revert bootstrap version upgrade
b7588f3
@r-ash
Update ghcr ref after project org move
dc4c162
@M-Kusumgar
fix table weirdness
cedf86f
@r-ash
Remove unused onUpdated import
12513fe
@r-ash
Merge pull request #1008 from hivtools/package-update-table-fix
fe1984c 
Fix table
@r-ash @M-Kusumgar
Update src/app/static/src/app/components/plots/table/TableDisplay.vue
db35e2b 
Co-authored-by: M-Kusumgar <98405247+M-Kusumgar@users.noreply.github.com>
@r-ash
Merge pull request #999 from hivtools/package-update
397bdb6 
Do all dependabot updates and fix issues
@r-ash
Update URLs after moving repo to hivtools org
be8436f
@r-ash
Update branch ref to use main
ce15883
@r-ash
Remove branch pin
37e7ccc
@r-ash r-ash requested a review from M-Kusumgar September 16, 2024 13:25
M-Kusumgar
M-Kusumgar approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@M-Kusumgar M-Kusumgar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skimmed some config files, ran it up and clicked through the form, all seemed fine! (as long as e2e test is genuine failure, we should probably add new screenshots for the table update spacing diff)

@r-ash r-ash merged commit 238a423 into main Sep 17, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-Kusumgar M-Kusumgar M-Kusumgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r-ash @M-Kusumgar