naomi-faster-input-time-series-data #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-ash
force-pushed
the
naomi-faster-input-time-series-data
branch
from
3351215 to
66f277f
Compare
r-ash
force-pushed
the
naomi-faster-input-time-series-data
branch
2 times, most recently
from
66f277f to
d9ed0ef
Compare
r-ash
force-pushed
the
naomi-faster-input-time-series-data
branch
from
91941f8 to
2c01ac3
Compare
r-ash
changed the base branch from
remove-old-endpoints
to
tmp-epic-plot-cleanup
r-ash
approved these changes
Oct 2, 2024
Comment on lines
+96
to
+97
| values <- dplyr::distinct(data, !!rlang::sym(id_column), !!rlang::sym(label_column)) | ||
| if (nrow(dplyr::distinct(data, !!rlang::sym(id_column))) != nrow(values)) { |
There was a problem hiding this comment.
Thanks, can you add dplyr and rlang into the DESCRIPTION please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically created PR from new naomi PR "Faster input time series data" - mrc-ide/naomi#439
Naomi PR has been merged in, so pointing to main in naomi. Also have replaced
uniquewithdplyr::distinctthat was part of the speed up work that I did. It is much faster thanunique.