Cleanup dependencies #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tesaguri
commented
Jan 2, 2021
Comment on lines
-33
to
+39
| impl<T: Connect> TimeoutConnector<T> { | ||
| impl<T> TimeoutConnector<T> | ||
| where | ||
| T: Service<Uri> + Send, | ||
| T::Response: AsyncRead + AsyncWrite + Send + Unpin, | ||
| T::Future: Send + 'static, | ||
| T::Error: Into<BoxError>, | ||
| { |
There was a problem hiding this comment.
The Connect trait still depends on http1/http2 features so I had to expand the trait bounds manually.
|
Thank you. I was waiting for that change to land. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hyper'shttp1andtcpfeatures by defaulthyper v0.14.2 exposed
connecttypes withouthttp1/http2features so they are not required anymore.bytesdependencybytesdoes not appear in trait bounds oftokio::io::Async{Read,Write}methods anymore so the dependency can be removed.