Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean out dup function and reminify. #4

Merged
merged 1 commit into from
Oct 13, 2016
Merged

Conversation

danielmcgraw
Copy link
Contributor

Removed genericLogger, looks to be a dup of log and never called. Recompressed after the change to make sure that it didn't stick around in the minified version.

@hkirat
Copy link
Owner

hkirat commented Oct 13, 2016

Hi,
Turns out genericLogger was a redundant function.
I love what you've done to the js file.
But I'm a bit worried about the minified file. It would be great if you would preserve the variable and function names in the minified file. Just make this change and I'll merge.
Thanks

@hkirat
Copy link
Owner

hkirat commented Oct 13, 2016

any update @danielmcgraw

@danielmcgraw
Copy link
Contributor Author

Correct me if I'm wrong, but it looks like you already have a min file that has names and vars that are minified so this should be about the same. We could do a whitespace only minification if you'd prefer?

@hkirat hkirat merged commit 823095f into hkirat:master Oct 13, 2016
@hkirat
Copy link
Owner

hkirat commented Oct 13, 2016

Yup seems so.
Sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants