Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve accronyms definition #206 #210

Merged
merged 3 commits into from
Mar 1, 2023
Merged

improve accronyms definition #206 #210

merged 3 commits into from
Mar 1, 2023

Conversation

oliveregger
Copy link
Contributor

see #206

  • added the translations for practitioner / organization
  • for the values only english or translations when no english
  • removed text narrative manual from naming system

@oliveregger oliveregger added ready for telco STU 4 Ballot Comments/Issues from the Ballot 2023 labels Feb 24, 2023
@oliveregger oliveregger self-assigned this Feb 24, 2023
@oliveregger
Copy link
Contributor Author

http://build.fhir.org/ig/hl7ch/ch-core/branches/oe_lang_206/qa.html

http://build.fhir.org/ig/hl7ch/ch-core/branches/oe_lang_206/StructureDefinition-ch-core-practitioner.html

http://build.fhir.org/ig/hl7ch/ch-core/branches/oe_lang_206/StructureDefinition-ch-core-organization.html

@oliveregger oliveregger linked an issue Feb 24, 2023 that may be closed by this pull request
Improve acronyms definition #206
Closed
@oliveregger oliveregger removed ready for telco STU 4 Ballot Comments/Issues from the Ballot 2023 labels Feb 24, 2023
qligier
qligier approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@qligier qligier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

Can't we link to the naming system in the resource? It is hard to find it otherwise.

@oliveregger
Copy link
Contributor Author

the description in element short is of type string, we cannot add a link from there. I added it to definition (which is of type mark down), however this only shows up on the "Detailed Description Tab":
http://build.fhir.org/ig/hl7ch/ch-core/branches/oe_lang_206/StructureDefinition-ch-core-organization-definitions.html

@qligier
Copy link
Member

qligier commented Feb 24, 2023

Thank you, it is better like this.

@oliveregger
Copy link
Contributor Author

Telco vom 1.3: 12 - 0 - 0

@oliveregger oliveregger merged commit 256816b into master Mar 1, 2023
@ziegm ziegm deleted the oe_lang_206 branch March 8, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qligier qligier qligier approved these changes

Assignees

@oliveregger oliveregger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve acronyms definition
2 participants
@oliveregger @qligier