-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selection modifiers #240
Selection modifiers #240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, this really feels great!
I've experienced an issue when a circle is present:
Traceback (most recent call last): File "/home/yoga/Dropbox/blend/addons/CAD_Sketcher/operators/select.py", line 89, in execute while select_extend(context): File "/home/yoga/Dropbox/blend/addons/CAD_Sketcher/operators/utilities.py", line 65, in select_extend if e.p1.selected or e.p2.selected: AttributeError: 'SlvsCircle' object has no attribute 'p1' Error: Python: Traceback (most recent call last): File "/home/yoga/Dropbox/blend/addons/CAD_Sketcher/operators/select.py", line 89, in execute while select_extend(context): File "/home/yoga/Dropbox/blend/addons/CAD_Sketcher/operators/utilities.py", line 65, in select_extend if e.p1.selected or e.p2.selected: AttributeError: 'SlvsCircle' object has no attribute 'p1'
Also it would be great to list the new shortcuts in the documentation, there's already some hints for the selection tool in docs/tools.md.
Hope to see you around :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to bother you again..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all, cool feature to have, good work 😄
Co-authored-by: Axel Soll <axel+github@soll.xyz>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just note some small details. IMO this can be merged if @amrsoll is also fine with the current state.
Thanks alot for the work all!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes because of unused imports :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good for squash merge :) thank you for the contribution!
🎉🎊 |
My first Open-source contribution :)
Related to #40
Added features with shortcuts:
select inverse
[CTRL + i]
self-explained
select extend
[CTRL + e]
Works different than in blender selecting-modes
This one selects next entities in chain
select extend all
[CTRL + SHIFT + e]
Selects all entities in chain