Using ACDL to call WebSDK

[cuzuco2]

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #442 and Fix#441

Test URLs:

• Before: https://main--bitdefender--hlxsites.hlx.page/solutions/
• After: https://pull_433--bitdefender--hlxsites.hlx.page/solutions/

[aem-code-sync]

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

• Re-run PSI checks
• Re-sync branch

Commits

• b3cb52a ✅ (latest)
• 01bb392 ✅
• 1380bac ✅
• 8a1d1a1 ✅
• 8c86011 ✅
• cabc934 ✅
• 39c982f ✅
• b2d9e6d ✅
• 421d4c3 ✅
• 17f560f ✅
• aff9017 ✅
• d976f97 ✅
• 2328a47 ✅
• 0c7512a ✅
• 396d0d5 ✅
• 936589b ✅
• 53a815e ✅
• 634a1fe ✅
• 02563f6 ✅
• e644f5d ✅
• a054d53 ✅
• 4e75e1f ✅
• 8324c35 ❌
• 89b1190 ❌
• a259e97 ❌
• 81f0204 ❌
• 29f7498 ❌
• 81e0f54 ❌

[aem-code-sync]

Page	Scores	Audits	Google
/solutions/		Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 421)

[vtsaplin]

@cuzuco2 Let's uncomment this and reference the new tag by adding an entry to the placeholders file.

[cuzuco2]

@vtsaplin you mean something like this?

const LANGUAGE_COUNTRY = getLanguageCountryFromPath(window.location.pathname);
// const LAUNCH_URL = 'https://assets.adobedtm.com';
const ENVIRONMENT = getEnvironment(window.location.hostname, LANGUAGE_COUNTRY.country);
// Load Adobe Experience platform data collection (Launch) script
// const { launchProdScript, launchStageScript, launchDevScript } = await fetchPlaceholders();
switch (ENVIRONMENT) {
case 'prod':
loadScript('https://assets.adobedtm.com/8a93f8486ba4/e7dc9e6549e5/launch-42a4d88f6f31.min.js'); break;
case 'stage':
loadScript('https://assets.adobedtm.com/8a93f8486ba4/e7dc9e6549e5/launch-d0a308d8ad78-staging.min.js'); break;
default:
loadScript('https://assets.adobedtm.com/8a93f8486ba4/e7dc9e6549e5/launch-aef7ddf31563-development.min.js'); break;
}

[vtsaplin]

@cuzuco2 Let's keep the code as it was before but make a tmp change in the scripts.js:

export function getEnvironment(hostname, country) {
  if (hostname.startsWith('pull_433')) {
    return 'dev';
  }
  if (hostname.includes('hlx.page') || hostname.includes('hlx.live')) {
    return 'stage';
  }
  if (hostname.includes(`.${country}`)) {
    return 'prod';
  }
  return 'dev';
}

You'd also need to change the dev ID in placeholders.

[cuzuco2]

@vtsaplin please review the changes, not sure why the ghost inspector is failing, I can't execute the test on my local machine

[vtsaplin]

@cuzuco2 The code here needs to be exactly as it was before. The change of URL should be done in the placeholder file on SharePoint. Here are the docs: https://www.aem.live/developer/placeholders

We'll fix the Ghost Inspector later. It has been broken for a while and is sensitive to changes because it relies on image comparison.

[cuzuco2]

@vtsaplin ok the function is now as it was before we began testing

[iuliag]

This should be the namespace for bitdefender

[andreibogdan]

@iuliag - we change it to _bitdefender. It is ok?

[vtsaplin]

@cuzuco2 We probably need to loas alloy.js first