EUI-1783: Support for deleting hidden field values #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure any existing value of a hidden field is deleted in the CCD backend, unless the field has the `retain_hidden_value` flag set to `true` (see RDM-9024), in which case the existing value will remain untouched.
Daniel-Lam
force-pushed
the
feature/EUI-1783-retain-hidden-field-value
branch
from
5f279e5 to
0fa11c7
Compare
andywilkinshmcts
approved these changes
Sep 29, 2020
src/shared/components/case-editor/case-edit-submit/case-edit-submit.component.ts
Show resolved
Hide resolved
src/shared/components/case-editor/case-edit-submit/case-edit-submit.component.ts
Outdated
Show resolved
Hide resolved
rayliangatos
approved these changes
Sep 29, 2020
adnanakgun
pushed a commit
that referenced
this pull request
Dec 2, 2020
* EUI-1783: Support for deleting hidden field values Ensure any existing value of a hidden field is deleted in the CCD backend, unless the field has the `retain_hidden_value` flag set to `true` (see RDM-9024), in which case the existing value will remain untouched. * Refactor `fg` parameter to `formGroup` for clarity, following suggestion from @rayliangatos
Daniel-Lam
added a commit
that referenced
this pull request
Dec 7, 2020
* EUI-1783: Support for deleting hidden field values Ensure any existing value of a hidden field is deleted in the CCD backend, unless the field has the `retain_hidden_value` flag set to `true` (see RDM-9024), in which case the existing value will remain untouched. * Refactor `fg` parameter to `formGroup` for clarity, following suggestion from @rayliangatos
paulhowes-HMCTS
pushed a commit
that referenced
this pull request
Dec 7, 2020
* EUI-1783: Support for deleting hidden field values Ensure any existing value of a hidden field is deleted in the CCD backend, unless the field has the `retain_hidden_value` flag set to `true` (see RDM-9024), in which case the existing value will remain untouched. * Refactor `fg` parameter to `formGroup` for clarity, following suggestion from @rayliangatos
Daniel-Lam
added a commit
that referenced
this pull request
Dec 7, 2020
* EUI-1783: Support for deleting hidden field values Ensure any existing value of a hidden field is deleted in the CCD backend, unless the field has the `retain_hidden_value` flag set to `true` (see RDM-9024), in which case the existing value will remain untouched. * Refactor `fg` parameter to `formGroup` for clarity, following suggestion from @rayliangatos
Daniel-Lam
added a commit
that referenced
this pull request
Dec 7, 2020
* EUI-1783: Support for deleting hidden field values Ensure any existing value of a hidden field is deleted in the CCD backend, unless the field has the `retain_hidden_value` flag set to `true` (see RDM-9024), in which case the existing value will remain untouched. * Refactor `fg` parameter to `formGroup` for clarity, following suggestion from @rayliangatos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/EUI-1783
Change description
Ensure any existing value of a hidden field is deleted in the CCD backend, unless the field has the
retain_hidden_valueflag set totrue(see RDM-9024), in which case the existing value will remain untouched.Note: This is a breaking change; for hidden fields, the default behaviour will change from the value being retained to the value being deleted in the CCD backend, unless the field has the
retain_hidden_valueflag set totrue.Does this PR introduce a breaking change? (check one with "x")