generated from hmcts/spring-boot-template
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NFDIV-4186] Set default org policies in HWF events #3891
Merged
adamg-hmcts
merged 5 commits into
master
from
nfdiv-4186-set-default-org-policies-in-hwf-events
Jul 24, 2024
Merged
[NFDIV-4186] Set default org policies in HWF events #3891
adamg-hmcts
merged 5 commits into
master
from
nfdiv-4186-set-default-org-policies-in-hwf-events
Jul 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CCD diff reportNo change |
CCD diff reportNo change |
FaisalMoJ
previously approved these changes
Jul 23, 2024
BWeeks-JusticeGovUK
previously approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth using the @requiredargsconstructor decorator on the class to avoid reliance on @Autowired, but it's fine.
adamg-hmcts
dismissed stale reviews from BWeeks-JusticeGovUK and FaisalMoJ
via
July 24, 2024 08:10
7dce006
CCD diff reportNo change |
adamg-hmcts
force-pushed
the
nfdiv-4186-set-default-org-policies-in-hwf-events
branch
from
July 24, 2024 08:32
7dce006
to
198e79a
Compare
adamg-hmcts
force-pushed
the
nfdiv-4186-set-default-org-policies-in-hwf-events
branch
from
July 24, 2024 08:33
198e79a
to
68cf136
Compare
CCD diff reportNo change |
BWeeks-JusticeGovUK
previously approved these changes
Jul 24, 2024
CCD diff reportNo change |
CCD diff reportNo change |
CCD diff reportNo change |
BWeeks-JusticeGovUK
approved these changes
Jul 24, 2024
adamg-hmcts
deleted the
nfdiv-4186-set-default-org-policies-in-hwf-events
branch
July 24, 2024 15:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
We need to ensure default org policies are set by the time cases progress to a post-submission state for NoC to work. These events were missed in the previous PR (NFDIV-4079)
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/NFDIV-4186
Pull request checklist
Before raising
Before merging
Note: Bug fixes, dependency updates and technical tasks do not directly impact the user experience and can be merged without QA and PO review.