NGR-1143 - Added confirm break clause page #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
app/uk/gov/hmrc/ngrraldfrontend/pages/ConfirmBreakClausePage.scala
Outdated
Show resolved
Hide resolved
app/uk/gov/hmrc/ngrraldfrontend/models/forms/ConfirmBreakClauseForm.scala
Show resolved
Hide resolved
test/uk/gov/hmrc/ngrraldfrontend/controllers/ConfirmBreakClauseControllerSpec.scala
Outdated
Show resolved
Hide resolved
test/uk/gov/hmrc/ngrraldfrontend/controllers/ConfirmBreakClauseControllerSpec.scala
Outdated
Show resolved
Hide resolved
test/uk/gov/hmrc/ngrraldfrontend/controllers/ConfirmBreakClauseControllerSpec.scala
Show resolved
Hide resolved
test/uk/gov/hmrc/ngrraldfrontend/models/forms/ConfirmBreakClauseFormSpec.scala
Outdated
Show resolved
Hide resolved
|
| case None => throw new NotFoundException("Failed to find answers") | ||
| } | ||
| case RepairsAndInsurancePage => _ => uk.gov.hmrc.ngrraldfrontend.controllers.routes.RentDatesAgreeStartController.show(NormalMode) //TODO Page not made yet | ||
| case ConfirmBreakClausePage => _ => uk.gov.hmrc.ngrraldfrontend.controllers.routes.LandlordController.show(NormalMode) //TODO This needs to be amended when the journey is completed |
There was a problem hiding this comment.
How come you have duplicate of the ConfirmBreakClausePage? Please link your page to previous page which is RepairsAndInsurancePage but only if they are on rent review journey.
|
There is one outstanding comment from previous. Can you please address it? |
anna-shen-hmrc
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.