This repository has been archived by the owner on Sep 20, 2021. It is now read-only.
Update to PHP 7.4/PHPUnit #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Hywan any update? I don't wish to spend time here going over TODOs if this does not make sense to you. If you were to punch a yellow "Abandon" button here, it'll work just as well as accepting this PR. I can't seriously push a replacement package to the people if the source isn't yet officially abandoned. |
|
@sanmai Thanks for all the work you put into cleaning up/improving the library! There is (at least) one other fix that I would need in order to be able to finish up my own fork of the Hoa\Regex library, would you accept a corresponding PR on sanmai/hoa-compiler, or should I rather roll another fork? |
|
I will be happy to consider a PR.
…--
Alexey
On Fri, May 1, 2020, at 22:55, blmage wrote:
@sanmai <https://github.com/sanmai> Thanks for all the work you put into cleaning up/improving the library!
There is (at least) one other fix <blmage@7f282dc> that I would need in order to be able to finish up my own fork of the Hoa\Regex <https://github.com/hoaproject/Regex> library, would you accept a corresponding PR on sanmai/hoa-compiler <https://github.com/sanmai/hoa-compiler>, or should I rather roll another fork?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#109 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABCBYHGASGCNDAE34FDNSDRPLIDPANCNFSM4LDVJUEQ>.
|
|
Since |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub seemingly cannot fathom that many files are not removed, just renamed. You should be able to see that all previous tests remain the same, only inside
atoum/notTest/.Changes:
TODO:
I think I want to be clear with my development approach. If you don't like it, and, say, if you're repelled by a switch to PHPUnit, and if you can't bear anything else... No problem, hope someone else could do that in a way to the best of your liking.