Backspace does not delete selected text

[ttmms]

Simple-keyboard version
2.29.72

Describe the bug
Selecting text and pressing backspace does not delete selected text

[hodgef]

Hello @tuomassa,

Thanks for reporting this, I'll have a look at it soon.

Edit: The fix will involve more extensive testing, so this might take a few days before being released.

[ttmms]

Thanks a lot for taking a look at it!

Another related behavior that virtual keyboard users are used to, is when you select a word for example and press any letter, it replaces selected text with that letter, without having to press backspace first

[hodgef]

Thanks @tuomassa, I added the changes to commit 1f335f6. However, this added some issues with the modules. I'll put this task on hold for now while I fix these. When everything is ready, I'll post here and release to npm. Thanks!

[Centaurnia]

Hi @hodgef Any update on this issue?

[hodgef]

Hey @Centaurnia and @tuomassa , really sorry for the delay. There was one modules bug that was driving me nuts.

I've now released v2.30.0 to a staging dist that you can use right away:

npm install simple-keyboard@2.30.0 --save

So for now it's accessible if you specify the version when installing (as shown above). This is because I still have to update the docs and check the other modules. Once I get that done I'll publish to the "latest" tag and mark this as truly complete.

Thanks!

[Centaurnia]

No Problem. Thanks a lot for the fix 👍

[karthika06031987]

We tried this fix for backspace but it is not working as expected.
When we select and do backspace, it is not getting deleted and also getting copy pasted as shown below -

Step1: Selecting multiple characters & Pressing backspace -The backspace doesnt delete the selected text.

Step2: We try to click random key after the text not getting deleted. This results in copy pasting of previously selected text

The cursor also remain in the middle of both the text sequences resulting in displaying the newly typed characters to appear in the middle

[Centaurnia]

Hi @hodgef, We get the same issue which @karthikaanoop posted in the above comment. Can you please take a look and give some solution.

[hodgef]

Hey guys, I cannot seem to reproduce this in the following 2.30.0 sandbox (Windows 10, Chrome 84):
https://codesandbox.io/s/festive-solomon-jpwl5

Can you reproduce that issue in the above sandbox? If not there might be something weird going on. Maybe it only happens on some devices.

Note: There's one known limitation with the input selection at the moment. For instance, when you select the text your mouseup has to be within the input bounds (since we don't update caret unless event.target = an input). It's kind of a drawback but the alternative would be to save the last input element in a var which I wouldn't like to do.

Best,
Francisco Hodge

[hodgef]

Hello guys - I've gone ahead and merged selection support to master. New users that install simple-keyboard will be getting this functionality. I'll keep an eye out for any issues that might arise with caret positioning.

Thanks!
Francisco Hodge

[riccardoflp]

Hi @hodgef,
if while I select the text I leave the input it does not work correctly.
I noticed it in this example.

[hodgef]

Hello @PozziCode,

Please refer to the comment above:
#637 (comment)

Note: There's one known limitation with the input selection at the moment. For instance, when you select the text your mouseup has to be within the input bounds (since we don't update caret unless event.target = an input). It's kind of a drawback but the alternative would be to save the last input element in a var which I wouldn't like to do.

As I mentioned here, I don't think this edge case warrants changing caret positioning code (which I prefer to leave as-is to prevent bigger issues). I also don't think a lot of people will select text in that manner.

If you come across other issues please feel free to create a new ticket. Thanks!

Regards,
Francisco Hodge