Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search and high-contrast mode to DRC site #11

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from

Conversation

feralresearch
Copy link
Contributor

@feralresearch feralresearch commented Oct 18, 2017

What this does

Addresses #7
Addresses #5
NB: I realize this is two distinct features and should have been two PRs, mea culpa

  1. Adds Lunr search to DRC site
  2. Adds high-contrast visual mode

Also: fixes a loading glitch where the submenus would sometimes appear and then disappear.

How to test

NOTE: Search doesn't need testing here, it's been superceeded by a different PR

Search:
1. Enter search term on search box on main page and hit "enter"

High Contrast:

  1. Click the "toggle contrast" button on the menu, observe the change
  2. Browse the site. Please report anything that looks broken or not high-contrast enough
  3. Please confirm the setting "sticks" even if you close the browser and return later

Fixes loading visual glitch on menus (should be hidden by default on load)

contrast adjustments
@SteveMarvin
Copy link

I need a PR link here.

@SteveMarvin
Copy link

There are a few scattered items that are not shifting out of the gray font (such as "Author"), but they are switched to a white background, which seems sufficient. ACCEPTED, with the caveat that the search functionality is not in yet.

@SteveMarvin SteveMarvin removed their request for review August 15, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants