Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "theme" property should accept more than 'dark' | 'light' | 'custom' #32

Closed
ouuan opened this issue Jun 6, 2022 · 1 comment
Closed

Comments

@ouuan
Copy link

ouuan commented Jun 6, 2022

For example, I may set theme to custom-dark/custom-light or something else, but now it's limited to 'dark' | 'light' | 'custom':

export type Theme = 'dark' | 'light' | 'custom';

I suggest changing it to either string or 'dark' | 'light' | `custom${string}`.

github-actions bot pushed a commit that referenced this issue Jun 8, 2022
### [1.2.4](v1.2.3...v1.2.4) (2022-06-08)

### Bug Fixes

* Change the theme type flexibly ([#32](#32)) ([0c7adaf](0c7adaf))
@hoiheart
Copy link
Owner

hoiheart commented Jun 8, 2022

@ouuan
The proposal was released in 1.2.4 🚀
Thanks 👍

@hoiheart hoiheart closed this as completed Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants