-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Rebase CDK pipeline version 2.9 #10
base: main
Are you sure you want to change the base?
Conversation
Watermelon AI SummaryErrorError: Request failed with status code 429 GitHub PRs
cdk-pipelines-github is an open repo and Watermelon will serve it for free. |
README.md
Outdated
@@ -43,6 +43,7 @@ Workflows. | |||
- [Waves for Parallel Builds](#waves-for-parallel-builds) | |||
- [Manual Approval Step](#manual-approval-step) | |||
- [Pipeline YAML Comments](#pipeline-yaml-comments) | |||
- [Common Configuration for Docker Asset Publishing Steps](#common-configuration-for-docker-asset-publishing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
@@ -46,7 +46,7 @@ jobs: | |||
- name: Install | |||
run: npm install --no-save cdk-assets | |||
- name: Authenticate Via GitHub Secrets | |||
uses: aws-actions/configure-aws-credentials@v1-node16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
@@ -15,11 +15,13 @@ export class DockerCredential { | |||
* found in your GitHub Secrets under these default keys. | |||
*/ | |||
public static dockerHub(creds: DockerHubCredentialSecrets = {}): DockerCredential { | |||
const username = creds.usernameKey ?? 'DOCKERHUB_USERNAME'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
API.md
Outdated
@@ -43,6 +43,7 @@ Workflows. | |||
- [Waves for Parallel Builds](#waves-for-parallel-builds) | |||
- [Manual Approval Step](#manual-approval-step) | |||
- [Pipeline YAML Comments](#pipeline-yaml-comments) | |||
- [Common Configuration for Docker Asset Publishing Steps](#common-configuration-for-docker-asset-publishing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
@@ -18,6 +18,25 @@ import { YamlFile } from './yaml-file'; | |||
const CDKOUT_ARTIFACT = 'cdk.out'; | |||
const ASSET_HASH_NAME = 'asset-hash'; | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
README.md
Outdated
@@ -43,6 +43,7 @@ Workflows. | |||
- [Waves for Parallel Builds](#waves-for-parallel-builds) | |||
- [Manual Approval Step](#manual-approval-step) | |||
- [Pipeline YAML Comments](#pipeline-yaml-comments) | |||
- [Common Configuration for Docker Asset Publishing Steps](#common-configuration-for-docker-asset-publishing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
@@ -18,6 +18,25 @@ import { YamlFile } from './yaml-file'; | |||
const CDKOUT_ARTIFACT = 'cdk.out'; | |||
const ASSET_HASH_NAME = 'asset-hash'; | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
@@ -15,11 +15,13 @@ export class DockerCredential { | |||
* found in your GitHub Secrets under these default keys. | |||
*/ | |||
public static dockerHub(creds: DockerHubCredentialSecrets = {}): DockerCredential { | |||
const username = creds.usernameKey ?? 'DOCKERHUB_USERNAME'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
API.md
Outdated
@@ -43,6 +43,7 @@ Workflows. | |||
- [Waves for Parallel Builds](#waves-for-parallel-builds) | |||
- [Manual Approval Step](#manual-approval-step) | |||
- [Pipeline YAML Comments](#pipeline-yaml-comments) | |||
- [Common Configuration for Docker Asset Publishing Steps](#common-configuration-for-docker-asset-publishing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
@@ -23,7 +23,7 @@ jobs: | |||
image: alpine | |||
steps: | |||
- name: Checkout | |||
uses: actions/checkout@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
API.md
Outdated
@@ -43,6 +43,7 @@ Workflows. | |||
- [Waves for Parallel Builds](#waves-for-parallel-builds) | |||
- [Manual Approval Step](#manual-approval-step) | |||
- [Pipeline YAML Comments](#pipeline-yaml-comments) | |||
- [Common Configuration for Docker Asset Publishing Steps](#common-configuration-for-docker-asset-publishing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
@@ -23,7 +23,7 @@ jobs: | |||
image: alpine | |||
steps: | |||
- name: Checkout | |||
uses: actions/checkout@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
@@ -15,11 +15,13 @@ export class DockerCredential { | |||
* found in your GitHub Secrets under these default keys. | |||
*/ | |||
public static dockerHub(creds: DockerHubCredentialSecrets = {}): DockerCredential { | |||
const username = creds.usernameKey ?? 'DOCKERHUB_USERNAME'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
README.md
Outdated
@@ -43,6 +43,7 @@ Workflows. | |||
- [Waves for Parallel Builds](#waves-for-parallel-builds) | |||
- [Manual Approval Step](#manual-approval-step) | |||
- [Pipeline YAML Comments](#pipeline-yaml-comments) | |||
- [Common Configuration for Docker Asset Publishing Steps](#common-configuration-for-docker-asset-publishing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
@@ -18,6 +18,25 @@ import { YamlFile } from './yaml-file'; | |||
const CDKOUT_ARTIFACT = 'cdk.out'; | |||
const ASSET_HASH_NAME = 'asset-hash'; | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
README.md
Outdated
@@ -43,6 +43,7 @@ Workflows. | |||
- [Waves for Parallel Builds](#waves-for-parallel-builds) | |||
- [Manual Approval Step](#manual-approval-step) | |||
- [Pipeline YAML Comments](#pipeline-yaml-comments) | |||
- [Common Configuration for Docker Asset Publishing Steps](#common-configuration-for-docker-asset-publishing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
@@ -18,6 +18,25 @@ import { YamlFile } from './yaml-file'; | |||
const CDKOUT_ARTIFACT = 'cdk.out'; | |||
const ASSET_HASH_NAME = 'asset-hash'; | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
@@ -15,11 +15,13 @@ export class DockerCredential { | |||
* found in your GitHub Secrets under these default keys. | |||
*/ | |||
public static dockerHub(creds: DockerHubCredentialSecrets = {}): DockerCredential { | |||
const username = creds.usernameKey ?? 'DOCKERHUB_USERNAME'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
@@ -23,7 +23,7 @@ jobs: | |||
image: alpine | |||
steps: | |||
- name: Checkout | |||
uses: actions/checkout@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
API.md
Outdated
@@ -43,6 +43,7 @@ Workflows. | |||
- [Waves for Parallel Builds](#waves-for-parallel-builds) | |||
- [Manual Approval Step](#manual-approval-step) | |||
- [Pipeline YAML Comments](#pipeline-yaml-comments) | |||
- [Common Configuration for Docker Asset Publishing Steps](#common-configuration-for-docker-asset-publishing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
API.md
Outdated
@@ -43,6 +43,7 @@ Workflows. | |||
- [Waves for Parallel Builds](#waves-for-parallel-builds) | |||
- [Manual Approval Step](#manual-approval-step) | |||
- [Pipeline YAML Comments](#pipeline-yaml-comments) | |||
- [Common Configuration for Docker Asset Publishing Steps](#common-configuration-for-docker-asset-publishing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
README.md
Outdated
@@ -43,6 +43,7 @@ Workflows. | |||
- [Waves for Parallel Builds](#waves-for-parallel-builds) | |||
- [Manual Approval Step](#manual-approval-step) | |||
- [Pipeline YAML Comments](#pipeline-yaml-comments) | |||
- [Common Configuration for Docker Asset Publishing Steps](#common-configuration-for-docker-asset-publishing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
API.md
Outdated
@@ -43,6 +43,7 @@ Workflows. | |||
- [Waves for Parallel Builds](#waves-for-parallel-builds) | |||
- [Manual Approval Step](#manual-approval-step) | |||
- [Pipeline YAML Comments](#pipeline-yaml-comments) | |||
- [Common Configuration for Docker Asset Publishing Steps](#common-configuration-for-docker-asset-publishing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
@@ -18,6 +18,25 @@ import { YamlFile } from './yaml-file'; | |||
const CDKOUT_ARTIFACT = 'cdk.out'; | |||
const ASSET_HASH_NAME = 'asset-hash'; | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
@@ -15,11 +15,13 @@ export class DockerCredential { | |||
* found in your GitHub Secrets under these default keys. | |||
*/ | |||
public static dockerHub(creds: DockerHubCredentialSecrets = {}): DockerCredential { | |||
const username = creds.usernameKey ?? 'DOCKERHUB_USERNAME'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
@@ -23,7 +23,7 @@ jobs: | |||
image: alpine | |||
steps: | |||
- name: Checkout | |||
uses: actions/checkout@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
@@ -18,6 +18,25 @@ import { YamlFile } from './yaml-file'; | |||
const CDKOUT_ARTIFACT = 'cdk.out'; | |||
const ASSET_HASH_NAME = 'asset-hash'; | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
API.md
Outdated
@@ -43,6 +43,7 @@ Workflows. | |||
- [Waves for Parallel Builds](#waves-for-parallel-builds) | |||
- [Manual Approval Step](#manual-approval-step) | |||
- [Pipeline YAML Comments](#pipeline-yaml-comments) | |||
- [Common Configuration for Docker Asset Publishing Steps](#common-configuration-for-docker-asset-publishing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains leftover multi-line comments. Please review or remove them.
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11376022157 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11395165958 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11412859915 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11421905996 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11430945786 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11450885010 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11470695557 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11490304218 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11509597665 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11527244949 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11536097812 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11545118626 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11564944240 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11584669129 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11603825376 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11622014469 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11638232588 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11646969222 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11655993201 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11675126567 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11694825753 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11714204506 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11733676868 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11751548884 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11760625837 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11769842792 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11788353721 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11808143039 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11828259924 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/11847906707 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow*
Rebases the CDK pipeline version 2.9