Fixed TypeScript definition for updateNode #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't get the updateNode function to work in my project. We are using TypeScript.
The TypeScript definition for the updateNode Function was incorrect.
The first parameter in the definition is a ISlTreeNode, but the code uses the path (number[]).
I changed the parameter from
nodeToUpdate: ISlTreeNode<TDataType>to
path: number[]Best regards,
Alex
Edit:
Alongside using this package, i noticed that the definition for the methods insert and remove also where missing in the TypeScript definition. I added them, too ;)