Skip to content

Conversation

championswimmer
Copy link
Contributor

synced with same dependency versions as jsonapi-server

@championswimmer
Copy link
Contributor Author

@pmcnr-hx please take a look

@pmcnr-hx
Copy link
Contributor

I was trying to do the same today but one of the tests is failing. It's not entirely trivial to spot why it is failing and I have to stop for today, but I will come back to it tomorrow. Once that test is passing we can do a release with all the dependencies updated.

@championswimmer
Copy link
Contributor Author

@pmcnr-hx there was lint error in mine because of using rest-spread ... operator. I have removed that now

@championswimmer championswimmer force-pushed the master branch 2 times, most recently from 87fd80d to a3ca428 Compare September 25, 2017 20:02
@championswimmer
Copy link
Contributor Author

@pmcnr-hx it works with Postgres now. Don't understand why MySQL fails

@pmcnr-hx
Copy link
Contributor

Thanks for the excellent work @championswimmer! As you have already noticed, I have merged a few of the outstanding PRs and updated the dependencies. Could you possibly rebase on master so the PR is cleaner and only includes commits for your fixes? If not, I'll cherry pick your fixes tomorrow into a branch off master and we should be able to do a final 2.0.0 release with all the tests passing.

Signed-off-by: Arnav Gupta <arnav@codingblocks.com>
@championswimmer
Copy link
Contributor Author

@pmcnr-hx done. now we are passing all 149 tests in mysql as well as postgres both

Signed-off-by: Arnav Gupta <arnav@codingblocks.com>
@championswimmer
Copy link
Contributor Author

Woohoo! Travis passed.

@championswimmer
Copy link
Contributor Author

@pmcnr-hx this looks good now ?

Copy link
Contributor

@pmcnr-hx pmcnr-hx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Amazing work! 😃 I'm going to merge and release 2.0.0. We can look into updating to Sequelize 4 tomorrow (there were a bunch of tests failing last time I tried). Thanks again for the fantastic work!

@pmcnr-hx pmcnr-hx merged commit c4fc7fa into holidayextras:master Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants