-
Notifications
You must be signed in to change notification settings - Fork 31
update to use latest dependencies #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@pmcnr-hx please take a look |
I was trying to do the same today but one of the tests is failing. It's not entirely trivial to spot why it is failing and I have to stop for today, but I will come back to it tomorrow. Once that test is passing we can do a release with all the dependencies updated. |
@pmcnr-hx there was lint error in mine because of using rest-spread |
87fd80d
to
a3ca428
Compare
@pmcnr-hx it works with Postgres now. Don't understand why MySQL fails |
Thanks for the excellent work @championswimmer! As you have already noticed, I have merged a few of the outstanding PRs and updated the dependencies. Could you possibly rebase on master so the PR is cleaner and only includes commits for your fixes? If not, I'll cherry pick your fixes tomorrow into a branch off master and we should be able to do a final 2.0.0 release with all the tests passing. |
Signed-off-by: Arnav Gupta <arnav@codingblocks.com>
0c73282
to
d502f72
Compare
@pmcnr-hx done. now we are passing all 149 tests in mysql as well as postgres both |
Signed-off-by: Arnav Gupta <arnav@codingblocks.com>
Woohoo! Travis passed. |
@pmcnr-hx this looks good now ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Amazing work! 😃 I'm going to merge and release 2.0.0. We can look into updating to Sequelize 4 tomorrow (there were a bunch of tests failing last time I tried). Thanks again for the fantastic work!
synced with same dependency versions as
jsonapi-server