Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show nightly clippy warnings as a comment on the PR #80

Merged
merged 2 commits into from
Dec 25, 2022

Conversation

jyn514
Copy link
Collaborator

@jyn514 jyn514 commented Dec 25, 2022

No description provided.

@jyn514 jyn514 force-pushed the example-pr branch 2 times, most recently from c4e4460 to ac09b76 Compare December 25, 2022 01:57
@jyn514 jyn514 changed the title test appveyor isn't running Show clippy warnings as a comment on the PR Dec 25, 2022
@jyn514
Copy link
Collaborator Author

jyn514 commented Dec 25, 2022

looks like github permissions don't allow this :( the closest I can get is the "security audit" outputs cargo-sarif generated. I'll add those I guess, they at least show up in the diff view which is better than nothing, and I can run -D warnings for clippy in addition.

@jyn514 jyn514 force-pushed the example-pr branch 2 times, most recently from 7920f2b to ae60ecc Compare December 25, 2022 19:18
@jyn514 jyn514 changed the title Show clippy warnings as a comment on the PR Show nightly clippy warnings as a comment on the PR Dec 25, 2022
@jyn514 jyn514 force-pushed the example-pr branch 3 times, most recently from 411f49e to e891e3d Compare December 25, 2022 19:48
@jyn514
Copy link
Collaborator Author

jyn514 commented Dec 25, 2022

ok turns out the fix was not to use an action at all lol, using https://github.com/actions/toolkit/blob/master/docs/commands.md#problem-matchers directly worked :)

@jyn514 jyn514 merged commit 42cf364 into holmgr:master Dec 25, 2022
@jyn514 jyn514 deleted the example-pr branch December 25, 2022 20:11
@marcospb19 marcospb19 mentioned this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant