Skip to content

chore(pytest): add pytest infra and convert test_01(issue #107) #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 24, 2025
Merged

chore(pytest): add pytest infra and convert test_01(issue #107) #118

merged 5 commits into from
Sep 24, 2025
+401 −1

Conversation

FaizaJibril
Copy link
Contributor

@FaizaJibril FaizaJibril commented Sep 22, 2025 •
edited
Loading

  • Add pytest dependencies to the test group in pyproject.toml
  • Add pytest CI workflow
  • Create tests/conftest.py with shared fixtures
  • Convert test_01 to pytest as tests/test_01_message_pytest.py
  • subsume pytest.ini into pyproject.toml
  • move pytest into its own folder, say tests\pytest,
  • reduce number of combinations of testing to python 3.11 & both OSes (windows & linux)

@FaizaJibril
feat: migrate from unittest to pytest framework (issue hololinked-dev…
a9d1771 
…#107)

- Add pytest dependencies to pyproject.toml
- Create CI/CD workflow for pytest (all OS, Python 3.11+)
- Convert test_01_message.py to pytest format
- Setup conftest.py with common fixtures
- Configure test ordering for test_01
- Enable coverage reporting (no upload)
@FaizaJibril
fix(pytest): correct pytest.ini syntax and limit CI to pytest file
8db5920 
- Fix collect_ignore INI syntax\n- Exclude unittest files from pytest collection\n- CI runs tests/test_01_message_pytest.py only to avoid import errors
@FaizaJibril
ci(pytest): disable Codecov upload for pytest workflow per issue holo…
8bf90e1 
…linked-dev#107
@FaizaJibril
test(pytest): move pytest config into pyproject; tests under tests/py…
6cdd859 
…test; ci: run py311 on ubuntu/windows
@FaizaJibril FaizaJibril changed the title chore(pytest): add pytest infra and convert test_01 chore(pytest): add pytest infra and convert test_01(issue #107) Sep 22, 2025
@FaizaJibril
Copy link
Contributor Author

Hi @VigneshVSV please let me know if it's been done as expected

VigneshVSV
VigneshVSV reviewed Sep 23, 2025
View reviewed changes
@VigneshVSV
Copy link
Collaborator

VigneshVSV commented Sep 23, 2025 •
edited
Loading

Apart fromt the comment above, I would say its ready to merge once you push the changes.

There is no need to create a new PR. you can just push here.

@VigneshVSV VigneshVSV merged commit 1b24404 into hololinked-dev:main Sep 24, 2025
9 of 11 checks passed
@VigneshVSV
Copy link
Collaborator

Hi, thanks a lot for this work! I merged it as it was good enough.

There was 1 more small error in the directory name of the pytest-dev , which was correct in the newer file you introduced but later removed. This not a problem as the migration is only starting.

I anyway have to fix the path of license file and streamline CI/CD, so I will make a followup PR to fix it.

Feel free to take some more issues if you are interested. There are also issues in other repositories or tech stack which you can find here - https://github.com/hololinked-dev#good-first-issues

Also tell your IoT friends about the project and put a star if you like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VigneshVSV VigneshVSV VigneshVSV left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FaizaJibril @VigneshVSV