Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed inheritance declaration of PanelWidgets #59

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Fixed inheritance declaration of PanelWidgets #59

merged 2 commits into from
Nov 17, 2023

Conversation

jlstevens
Copy link
Contributor

The __panel__ method isn't useful unless the class inherits from Viewer.

hoxbro
hoxbro reviewed Nov 17, 2023
View reviewed changes
holonote/app/panel.py Outdated Show resolved Hide resolved
@hoxbro
Copy link
Member

hoxbro commented Nov 17, 2023

Thank you

@hoxbro hoxbro enabled auto-merge (squash) November 17, 2023 12:42
@hoxbro hoxbro merged commit 3351184 into main Nov 17, 2023
15 checks passed
@hoxbro hoxbro deleted the viewer_fix branch November 17, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoxbro hoxbro hoxbro left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlstevens @hoxbro