Improve the combination logic for overlaying an annotator #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #98 will not alter performanceComparing Summary
|
droumis
requested changes
Apr 19, 2024
|
you are welcome to push to this PR. If you do please add test cases too. |
droumis
reviewed
Apr 20, 2024
droumis
reviewed
Apr 20, 2024
hoxbro
commented
Apr 22, 2024
holonote/annotate/annotator.py
Outdated
| return other * self.get_element(*other.kdims) | ||
| def _get_kdims_from_other_element(self, other): | ||
| if isinstance(other, hv.DynamicMap): | ||
| other = other.last if other.last is not None else other.callback() |
There was a problem hiding this comment.
I could imagine that other.callback() need some arguments and keyword arguments to work with streams etc.
|
Nice, looks good to me. Nice to know about |
droumis
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will now make it easier to add across overlays and layouts.