Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make explorer geo more optimized #1353

Merged
merged 7 commits into from
Jul 16, 2024
Merged

Make explorer geo more optimized #1353

merged 7 commits into from
Jul 16, 2024

Conversation

ahuang11
Copy link
Collaborator

  1. Batch call watchers so the loading symbol doesn't flicker (just tabbed everything over)
  2. If scatter/line, swap to points/path
  3. Projection doesn't always seem to be provided, so use crs instead

@ahuang11 ahuang11 requested a review from maximlt June 13, 2024 23:03
@ahuang11 ahuang11 changed the title Make geo more optimized Make explorer geo more optimized Jun 13, 2024
hvplot/ui.py Outdated Show resolved Hide resolved
hvplot/ui.py Outdated Show resolved Hide resolved
Copy link
Member

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah in fact there are two failing tests:

FAILED hvplot/tests/testui.py::test_explorer_geo_revise_kind[kind_tuple0] - TypeError: Constant parameter 'geo' cannot be modified
FAILED hvplot/tests/testui.py::test_explorer_geo_revise_kind[kind_tuple1] - TypeError: Constant parameter 'geo' cannot be modified

@ahuang11
Copy link
Collaborator Author

New test failure; prob should handle in a separate PR.
AttributeError: The geopandas.dataset has been deprecated and was removed in GeoPandas 1.0. You can get the original 'naturalearth_cities' data from [https://www.naturalearthdata.com/downloads/110m-cultural-vectors/.](https://www.naturalearthdata.com/downloads/110m-cultural-vectors/)

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.42%. Comparing base (6c96c7e) to head (e539fe6).
Report is 6 commits behind head on main.

Files Patch % Lines
hvplot/ui.py 96.42% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1353      +/-   ##
==========================================
+ Coverage   87.39%   88.42%   +1.03%     
==========================================
  Files          50       50              
  Lines        7490     7372     -118     
==========================================
- Hits         6546     6519      -27     
+ Misses        944      853      -91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maximlt maximlt merged commit 9d2a8da into main Jul 16, 2024
9 checks passed
@maximlt maximlt deleted the optimize_geo branch July 16, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants