-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make explorer geo more optimized #1353
Conversation
ahuang11
commented
Jun 13, 2024
- Batch call watchers so the loading symbol doesn't flicker (just tabbed everything over)
- If scatter/line, swap to points/path
- Projection doesn't always seem to be provided, so use crs instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah in fact there are two failing tests:
FAILED hvplot/tests/testui.py::test_explorer_geo_revise_kind[kind_tuple0] - TypeError: Constant parameter 'geo' cannot be modified
FAILED hvplot/tests/testui.py::test_explorer_geo_revise_kind[kind_tuple1] - TypeError: Constant parameter 'geo' cannot be modified
New test failure; prob should handle in a separate PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1353 +/- ##
==========================================
+ Coverage 87.39% 88.42% +1.03%
==========================================
Files 50 50
Lines 7490 7372 -118
==========================================
- Hits 6546 6519 -27
+ Misses 944 853 -91 ☔ View full report in Codecov by Sentry. |