Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement to Fields tab in explorer #811

Merged
merged 4 commits into from
Aug 3, 2022
Merged

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jul 30, 2022

Partially fixes #785 (2 and 4)

Indexes are now only added to x. For x and y because they are param.Selector needs to have the first value in the object specified, else they are None, which can give problem later on, e.g., when plotting.

self._plot was removed because it is called when triggering kind on the next line.

I have added the empty plot. Because when something fails, I think it is wrong to show the last working plot. The current configuration of settings does not output that plot. If people disagree with this, I could remove it from this PR and open another issue/PR to discuss it in.

@hoxbro hoxbro changed the title Explorer enhancement fields Enhancement to Fields tab in explorer Aug 1, 2022
@maximlt
Copy link
Member

maximlt commented Aug 3, 2022

Thanks @hoxbro !

@maximlt maximlt merged commit d25c6d4 into master Aug 3, 2022
@maximlt maximlt deleted the explorer_enhancement_fields branch August 3, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hvPlotExplorer issues with Fields pane
2 participants