Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please rename Spinner to NumberInput #1566

Closed
MarcSkovMadsen opened this issue Sep 7, 2020 · 3 comments
Closed

Please rename Spinner to NumberInput #1566

MarcSkovMadsen opened this issue Sep 7, 2020 · 3 comments
Labels
type: discussion Requiring community discussion

Comments

@MarcSkovMadsen
Copy link
Collaborator

The name Spinner is not very precise. It's actually misleading I believe.

image

Solution

Rename to NumberInput similar to TextInput. The NumberInput name is also closer to the name of the underlying html element. I can also see in the fast design system they call it a number-field (and text-field respectively).

@MarcSkovMadsen MarcSkovMadsen added the TRIAGE Default label for untriaged issues label Sep 7, 2020
@philippjfr philippjfr added type: discussion Requiring community discussion and removed TRIAGE Default label for untriaged issues labels Sep 25, 2020
@philippjfr
Copy link
Member

I'd be happy to rename it to NumberInput while keeping the old name for backward compatibility until 2.0.

@kcpevey
Copy link
Contributor

kcpevey commented Sep 25, 2020

Completely agree. When I hear spinner, in my head I think of the spinning gif. This would be much better.

@philippjfr
Copy link
Member

This was completed, they are now called FloatInput and IntInput.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: discussion Requiring community discussion
Projects
None yet
Development

No branches or pull requests

3 participants