Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of server prefix #2159

Merged
merged 8 commits into from
Apr 9, 2021
Merged

Improve handling of server prefix #2159

merged 8 commits into from
Apr 9, 2021

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 9, 2021

Handles relative paths to static resources in all cases including:

  1. Bokeh CSS and JS files
  2. Panel CSS and JS files
  3. Panel model JS and CSS dependencies
  4. Template CSS and JS files
  5. User defined CSS and JS files

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #2159 (4b6af70) into master (8710077) will increase coverage by 0.06%.
The diff coverage is 91.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2159      +/-   ##
==========================================
+ Coverage   83.79%   83.86%   +0.06%     
==========================================
  Files         182      182              
  Lines       21679    21762      +83     
==========================================
+ Hits        18166    18250      +84     
+ Misses       3513     3512       -1     
Impacted Files Coverage Δ
panel/command/serve.py 16.82% <ø> (-0.73%) ⬇️
panel/template/base.py 79.68% <75.00%> (-0.75%) ⬇️
panel/io/server.py 61.77% <86.20%> (+1.71%) ⬆️
panel/io/resources.py 81.14% <100.00%> (+2.57%) ⬆️
panel/io/state.py 60.69% <100.00%> (ø)
panel/tests/test_server.py 100.00% <100.00%> (ø)
panel/reactive.py 75.95% <0.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8710077...4b6af70. Read the comment docs.

@philippjfr philippjfr merged commit 88a7daa into master Apr 9, 2021
@philippjfr philippjfr deleted the prefix_handling branch April 9, 2021 17:02
philippjfr added a commit that referenced this pull request Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant