Remove all tornado imports #3252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jupyterlite is one client environment to run in. Another one would be pyodide directly. Imaging creating interactive apps using Python, Panel, HoloViz and PyData ecosystem without have to run a server in the background. That would be amazing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that in a pyiodide context the
panel.io.servermodule and all tornado based imports are not run. Additionally this sets the default comm to be'ipywidgets'so that all Panel objects are rendered using thejupyter_bokeh.BokehModelipywidget wrapper that also works in jupyterlite.