Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier for new users - Raise warning or error if extension not imported #2765

Closed
MarcSkovMadsen opened this issue Sep 21, 2021 · 0 comments · Fixed by #2766
Closed
Labels
type: enhancement Minor feature or improvement to an existing feature
Milestone

Comments

@MarcSkovMadsen
Copy link
Collaborator

I'm on Panel 0.12.1 and helping out a new user of Panel. His app was not looking as expected.

There was no error in server output. I showed him the browser console which he did not know. I could see there was some Tabulator error. I recognized the error as Tabulator not being in pn.extension("tabulator"). When adding this the problem was fixed.

The problem is here that as a new user he would probably not be able to identify, understand and solve the problem without help. And as a consequence he might end up dropping the framework.

Solution

Whenever you instantiate a custom extension check if it's included in pn.extension. If not raise error or warning.

@MarcSkovMadsen MarcSkovMadsen added the type: enhancement Minor feature or improvement to an existing feature label Sep 21, 2021
@MarcSkovMadsen MarcSkovMadsen added this to the Wishlist milestone Sep 21, 2021
@philippjfr philippjfr modified the milestones: Wishlist, v0.12.4 Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants