-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Dynamically reevaluate dependencies on subobjects #411
Conversation
(p.inst or p.cls).param.watch(_m_caller(self, n), p.name, p.what, queued=queued) | ||
|
||
self.initialized = True | ||
key = (n, p.name, p.what) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to make sure this key is sufficient to uniquely identify a callback.
param/parameterized.py
Outdated
@@ -864,6 +864,8 @@ def __set__(self,obj,val): | |||
obj.__dict__[self._internal_name] = val | |||
|
|||
self._post_setter(obj, val) | |||
if hasattr(val, '_setup_dependencies'): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally would have a better condition here, but can't do isinstance(val, Parameterized)
since this is evaluated before Parameterized exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.
d47325d
to
0d47be5
Compare
@philippjfr can you merge or close this pr. |
Implements #410