[WIP] Dynamically reevaluate dependencies on subobjects #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
commented
May 14, 2020
| (p.inst or p.cls).param.watch(_m_caller(self, n), p.name, p.what, queued=queued) | ||
|
|
||
| self.initialized = True | ||
| key = (n, p.name, p.what) |
There was a problem hiding this comment.
Need to make sure this key is sufficient to uniquely identify a callback.
philippjfr
commented
May 14, 2020
param/parameterized.py
Outdated
| @@ -864,6 +864,8 @@ def __set__(self,obj,val): | |||
| obj.__dict__[self._internal_name] = val | |||
|
|
|||
| self._post_setter(obj, val) | |||
| if hasattr(val, '_setup_dependencies'): | |||
There was a problem hiding this comment.
Ideally would have a better condition here, but can't do isinstance(val, Parameterized) since this is evaluated before Parameterized exists.
philippjfr
force-pushed
the
410_dynamic_depends
branch
from
d47325d
to
0d47be5
Compare
|
@philippjfr can you merge or close this pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #410