Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitPull: add support for ssh cloned GitHub repositories #241

Merged
merged 3 commits into from
Feb 6, 2018

Conversation

rpanfili
Copy link
Contributor

@rpanfili rpanfili commented Feb 2, 2018

I tried to support the exit code/output returned by GitHub using a repository cloned using ssh (e.g. private repos, etc) accordingly this official GitHub help page

@homeassistant
Copy link

Hi @rpanfili,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@pvizeli
Copy link
Member

pvizeli commented Feb 5, 2018

I long line :)

@rpanfili
Copy link
Contributor Author

rpanfili commented Feb 5, 2018

@pvizeli I know 😅 but otherwise I got some issues with the travis shellcheck routine checking the exit code indirectly and the output at the same time trying to avoid code duplication

@pvizeli
Copy link
Member

pvizeli commented Feb 6, 2018

Yeah no problem. I push it out in a hour

@pvizeli pvizeli merged commit 1757621 into home-assistant:master Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants