-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nintendo_parental icons #4650
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repository collects branding icons/logos. However, this PR seems not provide that. In this case, a Nintendo branding was expected.
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
@frenck would the Nintendo Switch icon be appropriate here? The integration itself is for the Parental Controls service that Nintendo offers - https://www.nintendo.co.uk/Hardware/Nintendo-Switch-Parental-Controls/Nintendo-Switch-Parental-Controls-1183145.html |
No, those are product branding, please use the manufacturer branding instead. ../Frenck |
@frenck ok, thanks, will update :) |
I can't find a icon for Nintendo that meets the criteria (although there is an old one from early 70s I believe), but a logo is possible still. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @pantherale0 👍
../Frenck
@pantherale0 This is official branding logo by Nintendo, for this specific app. |
@amitkeret that's what I used in the PR originally so no. |
If I'm not mistaken, you used only the icon in your original commit, before removing it? |
@amitkeret this was the review on that original commit. My understanding from that is this repo collects manufacturer brandings, not product branding (which is what the Nintendo Switch Parental Controls icon is). Feel free to open another PR for it though. It's not exactly something that is 'breaking'. |
Will do. Thank for your input, I love your integration! PS. note there are plenty of custom integrations which don't strictly adhere to official branding guidelines, and use this repo to display an icon for the integration... as a random example - gradual volume |
I think with the example you've given, that one is more of a helper (that could be achieved in this case using automation) rather than an integration with a product, service, application etc. built my a manufacturer. So perhaps that's why that one is ok? I think what's clear though is perhaps more guidance should be added to the documentation about what sort of things appropriate. I know there are the reqs for the formatting of the image, but I'm not sure if there is much about what that images themselves should actually contain (although happy to be corrected as it's been a while since I last looked at the branding docs). |
Proposed change
Adds icons for Nintendo Switch Parental Controls custom integration
https://github.com/pantherale0/ha-nintendoparentalcontrols
Type of change
Python wheels repository
Additional information
Checklist
icon.png
)icon@2x.png
)logo.png
)logo@2x.png
)