Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nintendo_parental icons #4650

Merged
merged 2 commits into from
Oct 8, 2023
Merged

Add nintendo_parental icons #4650

merged 2 commits into from
Oct 8, 2023

Conversation

pantherale0
Copy link
Contributor

Proposed change

Adds icons for Nintendo Switch Parental Controls custom integration

https://github.com/pantherale0/ha-nintendoparentalcontrols

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repository collects branding icons/logos. However, this PR seems not provide that. In this case, a Nintendo branding was expected.

../Frenck

@home-assistant home-assistant bot marked this pull request as draft September 13, 2023 07:03
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@pantherale0
Copy link
Contributor Author

@frenck would the Nintendo Switch icon be appropriate here?

The integration itself is for the Parental Controls service that Nintendo offers - https://www.nintendo.co.uk/Hardware/Nintendo-Switch-Parental-Controls/Nintendo-Switch-Parental-Controls-1183145.html

@frenck
Copy link
Member

frenck commented Sep 24, 2023

@frenck would the Nintendo Switch icon be appropriate here?

No, those are product branding, please use the manufacturer branding instead.

../Frenck

@pantherale0
Copy link
Contributor Author

@frenck ok, thanks, will update :)

@pantherale0
Copy link
Contributor Author

I can't find a icon for Nintendo that meets the criteria (although there is an old one from early 70s I believe), but a logo is possible still.

@pantherale0 pantherale0 marked this pull request as ready for review October 7, 2023 21:18
@home-assistant home-assistant bot requested a review from frenck October 7, 2023 21:18
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pantherale0 👍

../Frenck

@frenck frenck merged commit 33e30f9 into home-assistant:master Oct 8, 2023
5 checks passed
@amitkeret
Copy link
Contributor

@pantherale0
Can this be used?
logo.png

This is official branding logo by Nintendo, for this specific app.
Can be cropped to create an icon. I'd be happy to help.

@pantherale0
Copy link
Contributor Author

@amitkeret that's what I used in the PR originally so no.

@amitkeret
Copy link
Contributor

amitkeret commented Oct 17, 2024

If I'm not mistaken, you used only the icon in your original commit, before removing it?
I'm suggesting to change the logo to this one, including the text. In this way we add the expected manufacturer's branding for the app, as @frenck requested.
Then the icon can be added, as it is following the same branding design language.

@pantherale0
Copy link
Contributor Author

@amitkeret this was the review on that original commit.
#4650 (review)

My understanding from that is this repo collects manufacturer brandings, not product branding (which is what the Nintendo Switch Parental Controls icon is).

Feel free to open another PR for it though. It's not exactly something that is 'breaking'.

@amitkeret
Copy link
Contributor

Will do. Thank for your input, I love your integration!

PS. note there are plenty of custom integrations which don't strictly adhere to official branding guidelines, and use this repo to display an icon for the integration... as a random example - gradual volume

@pantherale0
Copy link
Contributor Author

I think with the example you've given, that one is more of a helper (that could be achieved in this case using automation) rather than an integration with a product, service, application etc. built my a manufacturer. So perhaps that's why that one is ok?

I think what's clear though is perhaps more guidance should be added to the documentation about what sort of things appropriate. I know there are the reqs for the formatting of the image, but I'm not sure if there is much about what that images themselves should actually contain (although happy to be corrected as it's been a while since I last looked at the branding docs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants