Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade ZHA dependency bellows #102471

Merged

Conversation

puddly
Copy link
Contributor

@puddly puddly commented Oct 21, 2023

Proposed change

Downgrade ZHA dependency bellows from 0.36.7 to 0.36.5 (changes), as the dependency upgrade (#102358) broke startup for DIY Zigbee coordinators running Tasmota firmware (e.g. Sonoff WiFi and Silvercrest).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zha can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zha Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@dmulcahey dmulcahey merged commit 864b69e into home-assistant:dev Oct 21, 2023
53 checks passed
frenck pushed a commit that referenced this pull request Oct 22, 2023
@ThomasCr
Copy link

ThomasCr commented Oct 23, 2023

mine was working after updateing my SONOFF Stick.... now it is broken again.

@ivorsmorenburg
Copy link

Mine still broken no upgrade and 2 Sonoff Sticks have been tested, restoring backups of the network and even HA, Can't create a new network from scratch. Logs show after the sonoff stick is "reset" by zippy and failing with "reset future", I can see connecting to some devices and working but ZHA can't finish the setup because this "reset error". That's my best guess

@frenck
Copy link
Member

frenck commented Oct 23, 2023

Alright, this is a PR, which has been merged and handled. This is not the place to track and discuss issues. For that specific thing, we have an issue tracker. Please use that :)

Issues are a lot better to track, than a closed PR.

Thanks 👍

../Frenck

@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZHA unable to start after update to 2023.10.4
7 participants