-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve RemoteEntity class #40605
Improve RemoteEntity class #40605
Conversation
It appears the discussion is still ongoing so this isn't mergeable yet. I'm going to mark this as a draft and it can be marked ready for review when the discussion is completed in the architecture issue. |
I think everyone agreed. There's not much to overthink about this, we covered everything in the issue. So I am reopening the PR. If anyone has a better idea, please join the discussion and I will mark this as a draft. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm relatively sure this isn't a breaking change because |
This is great! My RM4 Pro works just fine with the new integration but cant learn the RF commands and it looks like this will fix the issue. Sorry for my ignorance, but how do I know what release this fix will be in? |
Seems like we have consensus or at least lack of objection here so I'll merge this. |
Thank you! |
Proposed change
This PR is based on this discussion. We are improving the RemoteEntity. These are the proposed changes:
command_type
option toremote.learn_command
.remote.delete_command
service.Type of change
Example entry for
configuration.yaml
:Learn RF command
Delete a command
Delete a list of commands
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: