Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TaHoma integration #62607

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Conversation

iMicknl
Copy link
Contributor

@iMicknl iMicknl commented Dec 22, 2021

Breaking change

The broken tahoma integration has been removed and will be superseded by the overkiz integration in the future.

Proposed change

As discussed in #49403, it makes sense to remove tahoma from core and replace it with the new overkiz integration eventually.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @philklei, mind taking a look at this pull request as it has been labeled with an integration (tahoma) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@frenck
Copy link
Member

frenck commented Dec 23, 2021

I don't get this PR, the other isn't merged? As in, overkiz doesn't exist?

@iMicknl
Copy link
Contributor Author

iMicknl commented Dec 23, 2021

I don't get this PR, the other isn't merged? As in, overkiz doesn't exist?

They are not directly linked, and the tahoma integration is broken for over a year and since it won't be replace in the same domain, it makes more sense to just remove it?
(according to analytics, no one is using it anymore)

@frenck frenck merged commit c3917fc into home-assistant:dev Dec 23, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants