Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail template functions when no default specified #71687

Merged
merged 4 commits into from
May 13, 2022
Merged

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented May 11, 2022

Breaking change

The following template filters and functions will now fail instead of returning the input if the input is invalid and no default value is specified: round, multiply, log, sin, cos, tan, asin, acos, atan, atan2, sqrt, timestamp_custom, timestamp_local, timestamp_utc, as_timestamp, strptime, float, int.

Examples:
{{ "abc" | float }} - Will fail to render
{{ "abc" | float(default=5) }} - Will render as -5, no warning will be logged
{{ float("abc") }} - Will fail to render
{{ float("abc", default=5) }} - Will render as -5, no warning will be logged

Proposed change

Fail template functions when no default specified

Follow-up to #57470, #56453

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@emontnemery emontnemery requested a review from a team as a code owner May 11, 2022 13:13
@probot-home-assistant probot-home-assistant bot added core small-pr PRs with less than 30 lines. labels May 11, 2022
@balloob balloob merged commit 4885331 into dev May 13, 2022
@balloob balloob deleted the template_fail_no_default branch May 13, 2022 16:46
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2022
@frenck
Copy link
Member

frenck commented May 15, 2022

@balloob This PR was marked docs-missing, why did you merge it?

@emontnemery
Copy link
Contributor Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'float' should not return '0' by default
4 participants