Add HTTP(s) protocol support to Asuswrt #71899

ollo69 · 2022-05-15T14:54:30Z

Proposed change

This PR add the support to HTTP and HTTPS protocols to AsusWRT integration using this library.
HTTP protocol is the same used by the ASUS Router phone app provided by Asus, so potentially all devices that work with the application should be supported. This protocol in my tests is more reliable in device presence detection, and it also have the advantage to require less information for configuration, and therefore simplifies the initial and option config flows.
Sensors for the moment are limited to Download, Upload and related speeds, more sensors are available but I will leave this for future PR.

Support to existing SSH and TELNET protocol is maintained for compatibility, and config flow requests additional parameter in a second step only when one of this protocols are selected.

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes
This PR is related to issue: ASUSWRT integration: multiple SSH connections crash my modem #73978
Link to documentation pull request:

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
The code has been formatted using Black (black --fast homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

No score or internal
🥈 Silver
🥇 Gold
🏆 Platinum

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

probot-home-assistant · 2022-05-15T14:54:41Z

Hey there @kennedyshead, mind taking a look at this pull request as it has been labeled with an integration (asuswrt) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

kennedyshead · 2022-05-16T05:07:38Z

homeassistant/components/asuswrt/bridge.py

+        """Return a dictionary of available sensors for this bridge."""
+
+
+class AsusWrtLegacyBridge(AsusWrtBridge):


I think this should be removed, there is no real point in dividing into 2 versions?

And when doing that also remove me as code-owner would be good. (moved on from hass)

My idea was to maintain both considering the variety of routers in circulation. Can we wait for other opinions?

My idea was to maintain both considering the variety of routers in circulation. Can we wait for other opinions?

... Could't "commend out" or "strike-through" this, but i finally got it up and running, everything works as expected(from what i can see) ... i apologize for my inpatient nature, but im to old to deal with that :)
.........
If you want "assistant" in troubleshooting your "proposed" actions to verify
https://github.com/ollo69/ha_asuswrt_custom/tree/master/custom_components/asuswrt_custom , you better "shoot when the powder is dry" ... im currently without device-tracking and all, as i installed asuswrt_custom, and nothing works, hour ago today i had both ASUSWRT AND AsusRouter integrations working , so i might run out of patience, or time for testing/playing around :)
....

PS: Im still available (for testing purposes) just to justify my conscience :)

... Could't "commend out" or "strike-through" this, but i finally got it up and running, everything works as expected(from what i can see) ... i apologize for my inpatient nature, but im to old to deal with that :)

Never mind, good to know that this work for you. Any suggestion that may come using this implementation are welcome👍

I have just finished "evaluate" Asus_Router-Custom integration, and i fall back to ASUSWRT, Would be great if You could bring this Integration upto-date, and maybe as you mentioned in "#72591" ADD a few more sensors.
What first come to my mind, was (beside WAN_IP-Sensor) also Router-uptime.sensor

HA " UPnP/IGD " Core-Integration, include these 2 sensors, but from a usage-perspective would it be great if we don't have to use 2 different Core-Integrations, to get info's from the Router
Personally im not interested in DL/UL-Total or Speed etc., But essential info and "Tracking" initially, And using only 1 integration for this :)

As of now i have to use ASUSWRT for it's "Tracker" and "Connected Devices" AND UPnP/IGD, for "RouterUptime" and "WAN_IP"

shmick · 2022-07-12T01:46:16Z

@ollo69 does this PR need further review?

ollo69 · 2022-07-12T05:04:52Z

PR must be approved (and merged) by HA dev team.

shmick · 2022-08-10T18:17:51Z

@frenck can this be added into the next minor or major release?

shmick · 2022-08-17T15:05:54Z

@kennedyshead can you approve / merge this PR if everything looks ok?

ollo69 · 2022-08-17T15:13:23Z

@shmick,

PR must be reviewed by HA teams member and only them can merge PR in dev branch.
I suppose that review of this integration is taking long time because is a big PR, and review will require time that probably at this moment HA team do not have.
Unfortunately there are no way to split this in smaller PR, so we can only wait and hope that someone will take a look to this.

shmick · 2022-09-28T14:46:15Z

Pinging @frenck again to see we can get this merged soon

frenck · 2022-09-28T14:47:33Z

Please don't ping for reviews. As a matter of fact, I personally skip PRs asking for it (to prevent pinging from actually working).

There is a large queue of PRs to review. If you want things to go faster, please, join in helping out by reviewing the queues.

../Frenck

ollo69 · 2022-12-31T14:53:00Z

I put this PR in draft waiting for review of PR #84152

ollo69 · 2023-07-02T16:29:36Z

I close this PR, replaced by PR #95720

homeassistant added the cla-signed label May 15, 2022

probot-home-assistant bot added has-tests integration: asuswrt new-feature labels May 15, 2022

probot-home-assistant bot added the by-code-owner label May 15, 2022

kennedyshead suggested changes May 16, 2022

View reviewed changes

ollo69 mentioned this pull request May 17, 2022

[ASUSWRT] Aimesh devices not showing on HA #68344

Closed

ollo69 force-pushed the asuswrt-http-protocol branch from f3a57e3 to c1d260b Compare May 23, 2022 19:02

ollo69 mentioned this pull request May 27, 2022

AsusWrt sensors upload / download " state_class: total_increasing , Not working #72591

Closed

ollo69 force-pushed the asuswrt-http-protocol branch from c1d260b to 461d1d6 Compare May 28, 2022 11:26

ollo69 force-pushed the asuswrt-http-protocol branch 2 times, most recently from b8e05a8 to 79593c1 Compare June 11, 2022 09:51

ollo69 force-pushed the asuswrt-http-protocol branch from 79593c1 to d04e5bb Compare June 24, 2022 09:22

ollo69 force-pushed the asuswrt-http-protocol branch 2 times, most recently from aa70cab to fdb9649 Compare July 4, 2022 21:22

This was referenced Jul 7, 2022

ASUSWRT integration: multiple SSH connections crash my modem #73978

Closed

Add the component to HACS ollo69/ha_asuswrt_custom#3

Closed

ollo69 force-pushed the asuswrt-http-protocol branch from fdb9649 to 96378c6 Compare July 9, 2022 21:01

ollo69 force-pushed the asuswrt-http-protocol branch from 96378c6 to d69af6a Compare July 16, 2022 13:34

ollo69 mentioned this pull request Jul 21, 2022

continues login crashes AsusWRT #75056

Closed

ollo69 force-pushed the asuswrt-http-protocol branch from d69af6a to 2a18047 Compare July 30, 2022 11:04

ollo69 mentioned this pull request Sep 23, 2022

Just lost connection after updating to 2022.9.6 #78969

Closed

ollo69 force-pushed the asuswrt-http-protocol branch from db2c361 to be1f862 Compare September 24, 2022 09:11

ollo69 force-pushed the asuswrt-http-protocol branch 3 times, most recently from 220d760 to 4d00beb Compare December 2, 2022 16:04

ollo69 force-pushed the asuswrt-http-protocol branch 3 times, most recently from 8b12bf1 to f997aaf Compare December 17, 2022 09:03

ollo69 mentioned this pull request Dec 17, 2022

Add Bridge module to AsusWRT #84152

Merged

19 tasks

Add http(s) protocol to AsusWRT

1e8b926

ollo69 force-pushed the asuswrt-http-protocol branch from 30e7111 to 1e8b926 Compare December 20, 2022 02:36

ollo69 marked this pull request as draft December 31, 2022 14:53

ollo69 mentioned this pull request Apr 11, 2023

Add Asus Router integration #86084

Closed

19 tasks

ollo69 closed this Jul 2, 2023

ollo69 deleted the asuswrt-http-protocol branch July 2, 2023 16:29

github-actions bot locked and limited conversation to collaborators Jul 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add HTTP(s) protocol support to Asuswrt #71899

Add HTTP(s) protocol support to Asuswrt #71899

ollo69 commented May 15, 2022 •

edited

Loading

probot-home-assistant bot commented May 15, 2022

kennedyshead May 16, 2022

kennedyshead May 16, 2022

ollo69 May 16, 2022

boheme61 May 27, 2022 •

edited

Loading

ollo69 May 27, 2022 •

edited

Loading

boheme61 May 28, 2022 •

edited

Loading

shmick commented Jul 12, 2022

ollo69 commented Jul 12, 2022

shmick commented Aug 10, 2022

shmick commented Aug 17, 2022

ollo69 commented Aug 17, 2022

shmick commented Sep 28, 2022

frenck commented Sep 28, 2022 •

edited

Loading

ollo69 commented Dec 31, 2022

ollo69 commented Jul 2, 2023

		"""Return a dictionary of available sensors for this bridge."""


		class AsusWrtLegacyBridge(AsusWrtBridge):

Add HTTP(s) protocol support to Asuswrt #71899

Add HTTP(s) protocol support to Asuswrt #71899

Conversation

ollo69 commented May 15, 2022 • edited Loading

Proposed change

Type of change

Additional information

Checklist

probot-home-assistant bot commented May 15, 2022

kennedyshead May 16, 2022

Choose a reason for hiding this comment

kennedyshead May 16, 2022

Choose a reason for hiding this comment

ollo69 May 16, 2022

Choose a reason for hiding this comment

boheme61 May 27, 2022 • edited Loading

Choose a reason for hiding this comment

ollo69 May 27, 2022 • edited Loading

Choose a reason for hiding this comment

boheme61 May 28, 2022 • edited Loading

Choose a reason for hiding this comment

shmick commented Jul 12, 2022

ollo69 commented Jul 12, 2022

shmick commented Aug 10, 2022

shmick commented Aug 17, 2022

ollo69 commented Aug 17, 2022

shmick commented Sep 28, 2022

frenck commented Sep 28, 2022 • edited Loading

ollo69 commented Dec 31, 2022

ollo69 commented Jul 2, 2023

ollo69 commented May 15, 2022 •

edited

Loading

boheme61 May 27, 2022 •

edited

Loading

ollo69 May 27, 2022 •

edited

Loading

boheme61 May 28, 2022 •

edited

Loading

frenck commented Sep 28, 2022 •

edited

Loading