Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully Kiosk: Truncate long URLs #92347

Merged
merged 2 commits into from May 24, 2023
Merged

Fully Kiosk: Truncate long URLs #92347

merged 2 commits into from May 24, 2023

Conversation

mheath
Copy link
Contributor

@mheath mheath commented May 1, 2023

URL's longer than 256 characters will result in a
homeassistant.exceptions.InvalidStateError. This fixes that problem and adds 2 extra_state_attributes: full_url, and truncated.

Fixes #89249

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@mheath
Truncate long URLs
70659e3 
URL's longer than 256 characters will result in a
`homeassistant.exceptions.InvalidStateError`. This fixes that problem
and adds 2 extra_state_attributes: `full_url`, and `truncated`.

Fixes home-assistant#89249
@mheath mheath requested a review from cgarwood as a code owner May 1, 2023 22:16
@home-assistant
Copy link

home-assistant bot commented May 1, 2023

Hey there @cgarwood, mind taking a look at this pull request as it has been labeled with an integration (fully_kiosk) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of fully_kiosk can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign fully_kiosk Removes the current integration label and assignees on the pull request, add the integration domain after the command.

frenck
frenck previously requested changes May 2, 2023
View reviewed changes
homeassistant/components/fully_kiosk/sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft May 2, 2023 06:50
@home-assistant
Copy link

home-assistant bot commented May 2, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@mheath mheath marked this pull request as ready for review May 4, 2023 23:03
@home-assistant home-assistant bot requested a review from frenck May 4, 2023 23:03
Noltari
Noltari approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@Noltari Noltari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think that "Fully Kiosk" should be added to the PR title

@mheath mheath changed the title Truncate long URLs Fully Kiosk: Truncate long URLs May 9, 2023
emontnemery
emontnemery approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mheath 👍

@emontnemery emontnemery dismissed frenck’s stale review May 24, 2023 10:32

The requested changes have been implemented

@emontnemery emontnemery merged commit 2a7ba60 into home-assistant:dev May 24, 2023
24 checks passed
raman325 added a commit to raman325/home-assistant that referenced this pull request May 24, 2023
@raman325
Merge branch 'dev' of https://github.com/home-assistant/core into ind…
6d22501 
…icator

* 'dev' of https://github.com/home-assistant/core: (400 commits)
  Fix todoist state updates (home-assistant#91915)
  Bump pydeconz to v112 (home-assistant#91924)
  Fix directv attribute media_position_updated_at (home-assistant#92383)
  Add a DataUpdateCoordinator to Hydrawise (home-assistant#93223)
  Add UDP listener in Lightwave (home-assistant#85385)
  Prevent SensorEntity and RestoreEntity inheritance (home-assistant#88971)
  Implement OpenSky library (home-assistant#92814)
  Bump pygti and change the request for the new api version (home-assistant#92283)
  Fully Kiosk: Truncate long URLs (home-assistant#92347)
  Enable strict type checks of cloud (home-assistant#92576)
  Remove legacy translations from electrasmart (home-assistant#93446)
  Update aioairzone-cloud to v0.1.3 (home-assistant#93443)
  Add backup location and mount failed repair (home-assistant#93126)
  Remove unused zwave discovery logic (home-assistant#93436)
  Bump PySwitchbee to 1.8.0 (home-assistant#92348)
  remove template deprecated function `device_trigger.py` (home-assistant#93419)
  Fix reference string in data disk repair (home-assistant#93220)
  Use SnapshotAssertion in Renault tests (part 2) (home-assistant#92395)
  Add ability to unload demo integration (home-assistant#92515)
  Move Twitch constants to separate file (home-assistant#92605)
  ...
@mheath mheath deleted the truncate_long_url branch May 24, 2023 13:16
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Noltari Noltari Noltari approved these changes

@emontnemery emontnemery emontnemery approved these changes

@cgarwood cgarwood Awaiting requested review from cgarwood cgarwood is a code owner

@frenck frenck Awaiting requested review from frenck

Assignees

@cgarwood cgarwood

Labels
bugfix cla-signed has-tests integration: fully_kiosk Quality Scale: No score
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in logs: State max length is 255 characters.
5 participants
@mheath @frenck @Noltari @emontnemery @cgarwood