Add a DataUpdateCoordinator to Hydrawise #93223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @ptcryan, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
MartinHjelmare
changed the title
smoki3
approved these changes
May 19, 2023
epenet
requested changes
May 22, 2023
There was a problem hiding this comment.
A few comments:
- you should create a preliminary PR to centralise the existing constants into
const.py - you should then create a second preliminary PR to move the base entity into
entity.py - finally, implementing a data coordinator is usually an indication that you want to be involved in the development of the integration. You should consider adding yourself as a code owner in a third preliminary PR
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
This was referenced May 22, 2023
dknowles2
force-pushed
the
hydrawise-dataupdatecoordinator
branch
from
5d50ffe
to
8e36745
Compare
dknowles2
force-pushed
the
hydrawise-dataupdatecoordinator
branch
from
8e36745
to
7ec0fba
Compare
epenet
requested changes
May 23, 2023
epenet
reviewed
May 24, 2023
epenet
reviewed
May 24, 2023
epenet
requested changes
May 24, 2023
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
raman325
added a commit
to raman325/home-assistant
that referenced
this pull request
May 24, 2023
…icator * 'dev' of https://github.com/home-assistant/core: (400 commits) Fix todoist state updates (home-assistant#91915) Bump pydeconz to v112 (home-assistant#91924) Fix directv attribute media_position_updated_at (home-assistant#92383) Add a DataUpdateCoordinator to Hydrawise (home-assistant#93223) Add UDP listener in Lightwave (home-assistant#85385) Prevent SensorEntity and RestoreEntity inheritance (home-assistant#88971) Implement OpenSky library (home-assistant#92814) Bump pygti and change the request for the new api version (home-assistant#92283) Fully Kiosk: Truncate long URLs (home-assistant#92347) Enable strict type checks of cloud (home-assistant#92576) Remove legacy translations from electrasmart (home-assistant#93446) Update aioairzone-cloud to v0.1.3 (home-assistant#93443) Add backup location and mount failed repair (home-assistant#93126) Remove unused zwave discovery logic (home-assistant#93436) Bump PySwitchbee to 1.8.0 (home-assistant#92348) remove template deprecated function `device_trigger.py` (home-assistant#93419) Fix reference string in data disk repair (home-assistant#93220) Use SnapshotAssertion in Renault tests (part 2) (home-assistant#92395) Add ability to unload demo integration (home-assistant#92515) Move Twitch constants to separate file (home-assistant#92605) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This adds a
DataUpdateCoordinatorto the Hydrawise integration.(This is a retry of #92305, where I messed up my Git branch with a bad merge and pushed it upstream)
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: