Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Twitch constants to separate file #92605

Merged
merged 5 commits into from May 24, 2023
Merged

Move Twitch constants to separate file #92605

merged 5 commits into from May 24, 2023

Conversation

joostlek
Copy link
Member

@joostlek joostlek commented May 5, 2023

Proposed change

Move twitch constants to a separate file to prepare for config flow.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

gjohansson-ST
gjohansson-ST previously requested changes May 5, 2023
View reviewed changes
homeassistant/components/twitch/const.py Outdated Show resolved Hide resolved
homeassistant/components/twitch/const.py Outdated Show resolved Hide resolved
homeassistant/components/twitch/const.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

home-assistant bot commented May 5, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 5, 2023 12:00
@joostlek joostlek marked this pull request as ready for review May 5, 2023 12:10
@joostlek joostlek marked this pull request as draft May 5, 2023 12:13
@joostlek
Copy link
Member Author

joostlek commented May 5, 2023

Right, because before some parts weren't tested, the code coverage checks fail. I already made tests for these in #92418 (for the latest version) so I am not going to build tests I will overwrite anytime soon. I guess this PR will be dependent on that PR, something I did not expect and I don't like it :P

@gjohansson-ST
Copy link
Member

Right, because before some parts weren't tested, the code coverage checks fail. I already made tests for these in #92418 (for the latest version) so I am not going to build tests I will overwrite anytime soon. I guess this PR will be dependent on that PR, something I did not expect and I don't like it :P

You can break out those tests from the other PR and we start by adding those in.
Would probably also make it easier on both this PR and others to come

@joostlek
Copy link
Member Author

joostlek commented May 5, 2023

Right, because before some parts weren't tested, the code coverage checks fail. I already made tests for these in #92418 (for the latest version) so I am not going to build tests I will overwrite anytime soon. I guess this PR will be dependent on that PR, something I did not expect and I don't like it :P

You can break out those tests from the other PR and we start by adding those in. Would probably also make it easier on both this PR and others to come

A big difference is that in the newer version of the library is that it's async, so I am changing the whole way the tests are executed since the MagicMock used before doesn't support awaiting the constructor (await()).

@joostlek joostlek mentioned this pull request May 12, 2023
Closed
20 tasks
@joostlek
Merge branch 'dev' into twitch_const
2736495 
# Conflicts:
#	homeassistant/components/twitch/sensor.py
@joostlek
Update branch
9197641
@joostlek joostlek marked this pull request as ready for review May 22, 2023 07:12
emontnemery
emontnemery approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @joostlek 👍

@emontnemery emontnemery dismissed gjohansson-ST’s stale review May 24, 2023 07:18

The requested changes have been implemented

@emontnemery emontnemery merged commit 326d80f into home-assistant:dev May 24, 2023
24 checks passed
raman325 added a commit to raman325/home-assistant that referenced this pull request May 24, 2023
@raman325
Merge branch 'dev' of https://github.com/home-assistant/core into ind…
6d22501 
…icator

* 'dev' of https://github.com/home-assistant/core: (400 commits)
  Fix todoist state updates (home-assistant#91915)
  Bump pydeconz to v112 (home-assistant#91924)
  Fix directv attribute media_position_updated_at (home-assistant#92383)
  Add a DataUpdateCoordinator to Hydrawise (home-assistant#93223)
  Add UDP listener in Lightwave (home-assistant#85385)
  Prevent SensorEntity and RestoreEntity inheritance (home-assistant#88971)
  Implement OpenSky library (home-assistant#92814)
  Bump pygti and change the request for the new api version (home-assistant#92283)
  Fully Kiosk: Truncate long URLs (home-assistant#92347)
  Enable strict type checks of cloud (home-assistant#92576)
  Remove legacy translations from electrasmart (home-assistant#93446)
  Update aioairzone-cloud to v0.1.3 (home-assistant#93443)
  Add backup location and mount failed repair (home-assistant#93126)
  Remove unused zwave discovery logic (home-assistant#93436)
  Bump PySwitchbee to 1.8.0 (home-assistant#92348)
  remove template deprecated function `device_trigger.py` (home-assistant#93419)
  Fix reference string in data disk repair (home-assistant#93220)
  Use SnapshotAssertion in Renault tests (part 2) (home-assistant#92395)
  Add ability to unload demo integration (home-assistant#92515)
  Move Twitch constants to separate file (home-assistant#92605)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2023
@joostlek joostlek deleted the twitch_const branch May 27, 2023 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emontnemery emontnemery emontnemery approved these changes

@gjohansson-ST gjohansson-ST Awaiting requested review from gjohansson-ST

Assignees
No one assigned
Labels
cla-signed code-quality integration: twitch Quality Scale: No score
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joostlek @gjohansson-ST @emontnemery