Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reference string in data disk repair #93220

Merged
merged 2 commits into from May 24, 2023
Merged

Conversation

mdegat01
Copy link
Contributor

Proposed change

Screen Shot 2023-05-17 at 4 21 04 PM

It appears wrapping a translation placeholder in single quotes is a way of escaping it that I wasn't aware of. Removing those so it subs in the value instead of popping out the literal text {reference}

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/supervisor, mind taking a look at this pull request as it has been labeled with an integration (hassio) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hassio can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign hassio Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@frenck frenck marked this pull request as draft May 21, 2023 14:11
@frenck
Copy link
Member

frenck commented May 21, 2023

I've marked this PR, as changes are requested that need to be processed.
Please un-draft it once it is ready for review again by clicking the "Ready for review" button.

Thanks! 👍

../Frenck

Learn more about our pull request process.

@mdegat01 mdegat01 marked this pull request as ready for review May 23, 2023 19:57
@mdegat01 mdegat01 requested a review from ludeeus May 23, 2023 19:57
@emontnemery emontnemery merged commit 2906caf into dev May 24, 2023
48 checks passed
@emontnemery emontnemery deleted the fix-reference-string branch May 24, 2023 07:42
raman325 added a commit to raman325/home-assistant that referenced this pull request May 24, 2023
…icator

* 'dev' of https://github.com/home-assistant/core: (400 commits)
  Fix todoist state updates (home-assistant#91915)
  Bump pydeconz to v112 (home-assistant#91924)
  Fix directv attribute media_position_updated_at (home-assistant#92383)
  Add a DataUpdateCoordinator to Hydrawise (home-assistant#93223)
  Add UDP listener in Lightwave (home-assistant#85385)
  Prevent SensorEntity and RestoreEntity inheritance (home-assistant#88971)
  Implement OpenSky library (home-assistant#92814)
  Bump pygti and change the request for the new api version (home-assistant#92283)
  Fully Kiosk: Truncate long URLs (home-assistant#92347)
  Enable strict type checks of cloud (home-assistant#92576)
  Remove legacy translations from electrasmart (home-assistant#93446)
  Update aioairzone-cloud to v0.1.3 (home-assistant#93443)
  Add backup location and mount failed repair (home-assistant#93126)
  Remove unused zwave discovery logic (home-assistant#93436)
  Bump PySwitchbee to 1.8.0 (home-assistant#92348)
  remove template deprecated function `device_trigger.py` (home-assistant#93419)
  Fix reference string in data disk repair (home-assistant#93220)
  Use SnapshotAssertion in Renault tests (part 2) (home-assistant#92395)
  Add ability to unload demo integration (home-assistant#92515)
  Move Twitch constants to separate file (home-assistant#92605)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants