Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused zwave discovery logic #93436

Merged
merged 4 commits into from May 24, 2023
Merged

Remove unused zwave discovery logic #93436

merged 4 commits into from May 24, 2023

Conversation

raman325
Copy link
Contributor

@raman325 raman325 commented May 24, 2023 •
edited

Proposed change

There were several unused checks that may be useful in the future but we don't need to include logic for them until that comes up. Additionally, manufacturer ID, product ID, and product type are usually used together so I combined the logic into one if statement. I avoided doing that elsewhere - I think it makes sense here.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@raman325 raman325 requested a review from a team as a code owner May 24, 2023 06:06
@home-assistant
Copy link

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zwave_js can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zwave_js Removes the current integration label and assignees on the pull request, add the integration domain after the command.

emontnemery
emontnemery approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @raman325 👍

@MartinHjelmare MartinHjelmare merged commit 9b53484 into home-assistant:dev May 24, 2023
24 checks passed
@raman325 raman325 deleted the discovery branch May 24, 2023 12:32
raman325 added a commit to raman325/home-assistant that referenced this pull request May 24, 2023
@raman325
Merge branch 'dev' of https://github.com/home-assistant/core into ind…
6d22501 
…icator

* 'dev' of https://github.com/home-assistant/core: (400 commits)
  Fix todoist state updates (home-assistant#91915)
  Bump pydeconz to v112 (home-assistant#91924)
  Fix directv attribute media_position_updated_at (home-assistant#92383)
  Add a DataUpdateCoordinator to Hydrawise (home-assistant#93223)
  Add UDP listener in Lightwave (home-assistant#85385)
  Prevent SensorEntity and RestoreEntity inheritance (home-assistant#88971)
  Implement OpenSky library (home-assistant#92814)
  Bump pygti and change the request for the new api version (home-assistant#92283)
  Fully Kiosk: Truncate long URLs (home-assistant#92347)
  Enable strict type checks of cloud (home-assistant#92576)
  Remove legacy translations from electrasmart (home-assistant#93446)
  Update aioairzone-cloud to v0.1.3 (home-assistant#93443)
  Add backup location and mount failed repair (home-assistant#93126)
  Remove unused zwave discovery logic (home-assistant#93436)
  Bump PySwitchbee to 1.8.0 (home-assistant#92348)
  remove template deprecated function `device_trigger.py` (home-assistant#93419)
  Fix reference string in data disk repair (home-assistant#93220)
  Use SnapshotAssertion in Renault tests (part 2) (home-assistant#92395)
  Add ability to unload demo integration (home-assistant#92515)
  Move Twitch constants to separate file (home-assistant#92605)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@emontnemery emontnemery emontnemery approved these changes

Assignees
No one assigned
Labels
cla-signed code-quality integration: zwave_js Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raman325 @MartinHjelmare @emontnemery