WIP: Yi Home Cameras #9743

bachya · 2017-10-08T02:27:45Z

Description:

Adds support for YI Home Cameras running the alternative firmware for Xiaomi Cameras based on Hi3518e Chipset. Awaiting some underlying library changes before pressing forward.

Related issue (if applicable): N/A

Pull request in home-assistant.github.io with documentation (if applicable): TBD

Example entry for `configuration.yaml` (if applicable):

camera:
  - platform: yi
    name: Kitchen Camera
    host: '192.168.1.100'
    username: root
    password: my_password_123
    ffmpeg_arguments: '-vf scale=800:450'

Checklist:

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

Local tests with tox run successfully. Your PR cannot be merged unless tests pass
New dependencies have been added to the REQUIREMENTS variable (example).
New dependencies are only imported inside functions that use them (example).
New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
New files were added to .coveragerc.

houndci-bot · 2017-10-08T03:04:26Z

homeassistant/components/camera/yi.py

@@ -0,0 +1,144 @@
+"""
+This component provides basic support for Xiaomi Cameras (HiSilicon Hi3518e V200).


line too long (82 > 79 characters)

houndci-bot · 2017-10-08T03:04:26Z

homeassistant/components/camera/yi.py

@@ -0,0 +1,144 @@
+"""
+This component provides basic support for Xiaomi Cameras (HiSilicon Hi3518e V200).


line too long (82 > 79 characters)

balloob · 2017-10-08T04:59:34Z

homeassistant/components/camera/yi.py

+        """Retrieve the latest video file from the customized Yi FTP server."""
+        from aioftp import ClientSession
+
+        async with ClientSession(self.host, 21, self.user,


We are still supporting Python 3.4 till the beginning of 2018. This means that we do not support async and await keywords. Use yield from / @asyncio.coroutine

That also means that aioftp cannot be used as it requires a minimum of Python 3.5.

Understood. After considering it, I’m okay backing down to ftplib; will implement soon.

balloob · 2017-10-08T05:00:44Z

homeassistant/components/camera/yi.py

+                                 self.passwd) as client:
+            dirs = [
+                p
+                for p, i in sorted(


This is unreadable, please just write it as a normal for loop

* Make Arlo battery_level icon dynamic * makes lint happy

…i changes (home-assistant#9454) * bump the pyhs100 version and fix api changes * switch.tplink: avoid I/O during __init__ * initialize _name to None in __init__ * update requirements_all.txt for the new version

* Add Helpers bind_hass functionality * Update other helpers

bachya · 2017-10-08T16:33:37Z

@balloob: I've rewritten this using ftplib. One area of concern I have has to do with image retrieval. Since I'm a relative newbie to async programming, I'd appreciate your input.

I'm using @pvizeli's ha-ffmpeg library to process the MP4; since his method to retrieve an image from a stream is a coroutine, I imagine I need the async_camera_image method (instead of camera_image). Unless I'm mistaken, doesn't line 122 represent IO going on inside the event loop?

I'm using this as a custom component in my HASS install and everything appears fine (camera is updating, no timer desynchronization, etc.), but would love to be sure.

EDIT: Just saw my first timer desynchronization on a fresh install with nothing but this platform running.

EDIT 2: I think I figured out the async_add_job method; giving that a shot.

* New Skybell platform with components * Added skybell components to omit. * Preemptively fixing lint issues (hopefully). * Removed unused variable. * Requested changes. * Additional CRs * Hopefully the last of the CR's!

* Tesla bug fixes. * Added myself to CODEOWNERS for tesla.

There is an off by one error that causes period exceptions. Fix this.

* Added is_closed * whitespaces -- * removed whitespace

* Support for Wink Dome siren/chimes

This fixes some bugs with interfacing with yamaha receivers, including closing bug home-assistant#5209.

bachya · 2017-10-09T19:56:53Z

Whoa – not sure what happened with that rebase. Going to close this out and submit a new PR (with the latest code).

bachya added 3 commits October 7, 2017 17:20

Playing around...

4498c39

More tinkering

7fa25f7

First "alpha" in place

d048656

bachya requested a review from andrey-git as a code owner October 8, 2017 02:27

homeassistant added new-platform platform: camera.ffmpeg cla-signed labels Oct 8, 2017

bachya added 2 commits October 7, 2017 20:28

Removing asyncio (unnecessary)

9ac2a07

pylint

cdfa8ed

houndci-bot reviewed Oct 8, 2017

View reviewed changes

balloob reviewed Oct 8, 2017

View reviewed changes

balloob and others added 6 commits October 8, 2017 09:26

Fix I/O in event loop by Arlo alarm control panel (home-assistant#9738)

9eff9fa

Make Arlo battery_level icon dynamic (home-assistant#9747)

f56bdd2

* Make Arlo battery_level icon dynamic * makes lint happy

Fix for TypeError in synology camera (home-assistant#9754)

e89e642

switch.tplink, light.tplink: bump the pyhs100 version and adapt to ap…

e19e9a1

…i changes (home-assistant#9454) * bump the pyhs100 version and fix api changes * switch.tplink: avoid I/O during __init__ * initialize _name to None in __init__ * update requirements_all.txt for the new version

RFC: Use bind_hass for helpers (home-assistant#9745)

ca54bbf

* Add Helpers bind_hass functionality * Update other helpers

Rewrite using ftplib

3e2740c

balloobbot added the platform label Oct 8, 2017

Fixing linter issues

13b02c9

homeassistant added the cla-signed label Oct 8, 2017

bachya and others added 6 commits October 8, 2017 10:54

Missing @asyncio.coroutine

2bb99c5

Added try/except for cases where video folder is empty

22c44fc

Empty folder should be info, not warning

214e2ae

Attempting fix of image blocking IO

5116acd

Skybell (home-assistant#9681)

8132989

* New Skybell platform with components * Added skybell components to omit. * Preemptively fixing lint issues (hopefully). * Removed unused variable. * Requested changes. * Additional CRs * Hopefully the last of the CR's!

add myself to yeelight owners, too (home-assistant#9759)

672ff96

zabuldon and others added 5 commits October 9, 2017 14:38

Tesla bug fixes. (home-assistant#9774)

9abd0fb

* Tesla bug fixes. * Added myself to CODEOWNERS for tesla.

Fix off by one error in arwn platform (home-assistant#9781)

d0ec930

There is an off by one error that causes period exceptions. Fix this.

missing is_closed ( rflink cover fix ) (home-assistant#9776)

cb52b80

* Added is_closed * whitespaces -- * removed whitespace

Wink dome siren support (home-assistant#9667)

5232f2a

* Support for Wink Dome siren/chimes

Bump rxv library to 0.5.1 (home-assistant#9784)

581e2f2

This fixes some bugs with interfacing with yamaha receivers, including closing bug home-assistant#5209.

bachya mentioned this pull request Oct 9, 2017

AttributeError: 'bool' object has no attribute 'read' home-assistant-libs/ha-ffmpeg#18

Closed

bachya added 13 commits October 9, 2017 11:51

Playing around...

bf8bfbf

More tinkering

47e50e1

First "alpha" in place

a2e2732

Removing asyncio (unnecessary)

aeebc47

pylint

655f69a

Rewrite using ftplib

b287128

Fixing linter issues

4e5902d

Missing @asyncio.coroutine

05d6a54

Added try/except for cases where video folder is empty

bb8da92

Empty folder should be info, not warning

a77b035

Attempting fix of image blocking IO

e2c3919

Rebasing

de9d642

Owner-requested changes + merge

d7c27e9

bachya requested a review from a team as a code owner October 9, 2017 18:23

homeassistant added the cla-signed label Oct 9, 2017

bachya closed this Oct 9, 2017

bachya deleted the yi-camera branch October 9, 2017 19:57

bachya mentioned this pull request Oct 9, 2017

Yi Home Cameras #9787

Merged

6 tasks

home-assistant locked and limited conversation to collaborators Mar 3, 2018

ghost added integration: ffmpeg integration: yi and removed platform: camera.ffmpeg labels Mar 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Yi Home Cameras #9743

WIP: Yi Home Cameras #9743

bachya commented Oct 8, 2017 •

edited

Loading

houndci-bot Oct 8, 2017

houndci-bot Oct 8, 2017

balloob Oct 8, 2017

balloob Oct 8, 2017

bachya Oct 8, 2017

balloob Oct 8, 2017

bachya commented Oct 8, 2017 •

edited

Loading

bachya commented Oct 9, 2017

		@@ -0,0 +1,144 @@
		"""
		This component provides basic support for Xiaomi Cameras (HiSilicon Hi3518e V200).

WIP: Yi Home Cameras #9743

WIP: Yi Home Cameras #9743

Conversation

bachya commented Oct 8, 2017 • edited Loading

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

houndci-bot Oct 8, 2017

Choose a reason for hiding this comment

houndci-bot Oct 8, 2017

Choose a reason for hiding this comment

balloob Oct 8, 2017

Choose a reason for hiding this comment

balloob Oct 8, 2017

Choose a reason for hiding this comment

bachya Oct 8, 2017

Choose a reason for hiding this comment

balloob Oct 8, 2017

Choose a reason for hiding this comment

bachya commented Oct 8, 2017 • edited Loading

bachya commented Oct 9, 2017

bachya commented Oct 8, 2017 •

edited

Loading

Example entry for `configuration.yaml` (if applicable):

bachya commented Oct 8, 2017 •

edited

Loading