-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Freebox Home battery sensor #99756
Merged
Quentame
merged 1 commit into
home-assistant:dev
from
hacf-fr:freebox/fix-battery-sensor
Sep 7, 2023
Merged
Fix Freebox Home battery sensor #99756
Quentame
merged 1 commit into
home-assistant:dev
from
hacf-fr:freebox/fix-battery-sensor
Sep 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
Quentame
added
integration: freebox
has-tests
by-code-owner
bugfix
small-pr
PRs with less than 30 lines.
labels
Sep 6, 2023
gjohansson-ST
requested changes
Sep 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not obvsious in this PR what is being fixed. Update the PR description to clarify what is broken. Thanks
Quentame
force-pushed
the
freebox/fix-battery-sensor
branch
from
September 7, 2023 08:18
41fc0c0
to
8d41a5a
Compare
Quentame
force-pushed
the
freebox/fix-battery-sensor
branch
from
September 7, 2023 08:35
8d41a5a
to
82adfd0
Compare
Quentame
force-pushed
the
freebox/fix-battery-sensor
branch
from
September 7, 2023 08:43
82adfd0
to
26fdc63
Compare
gjohansson-ST
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Quentame 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Split of #99365
fix bugs:
HOME_COMPATIBLE_CATEGORIES
to not be filtered by the router, battery sensors are now not created: issue from Add Freebox Home battery sensor #99222 in 2023.9Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: