Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Freebox Home battery sensor #99756

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

Quentame
Copy link
Member

@Quentame Quentame commented Sep 6, 2023

Proposed change

Split of #99365

fix bugs:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@Quentame Quentame added this to the 2023.9.1 milestone Sep 6, 2023
@Quentame Quentame added cla-recheck and removed small-pr PRs with less than 30 lines. labels Sep 6, 2023
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not obvsious in this PR what is being fixed. Update the PR description to clarify what is broken. Thanks

tests/components/freebox/common.py Outdated Show resolved Hide resolved
@Quentame
Copy link
Member Author

Quentame commented Sep 6, 2023

It's not obvsious in this PR what is being fixed. Update the PR description to clarify what is broken. Thanks

PR descriptions from #99756 and #99757 were exchanged.

Updated !

@gjohansson-ST gjohansson-ST reopened this Sep 6, 2023
@Quentame Quentame enabled auto-merge (squash) September 6, 2023 22:04
@Quentame Quentame force-pushed the freebox/fix-battery-sensor branch from 41fc0c0 to 8d41a5a Compare September 7, 2023 08:18
@Quentame Quentame force-pushed the freebox/fix-battery-sensor branch from 8d41a5a to 82adfd0 Compare September 7, 2023 08:35
@Quentame Quentame force-pushed the freebox/fix-battery-sensor branch from 82adfd0 to 26fdc63 Compare September 7, 2023 08:43
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Quentame 👍

@Quentame Quentame merged commit c3e14d0 into home-assistant:dev Sep 7, 2023
@Quentame Quentame deleted the freebox/fix-battery-sensor branch September 7, 2023 15:28
teharris1 pushed a commit to teharris1/home-assistant that referenced this pull request Sep 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants