Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more busy codes for Epson #99771

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

pszafer
Copy link
Contributor

@pszafer pszafer commented Sep 6, 2023

Proposed change

I found out that some projectors returns different busy codes 02, 2, "2".
I added those.
I can't test these changes as I don't have running projector right now.
Changelog of the library: https://github.com/pszafer/epson_projector/releases/tag/v0.5.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include a link to the changelog of the library in the PR description

@home-assistant home-assistant bot marked this pull request as draft September 7, 2023 10:12
@home-assistant
Copy link

home-assistant bot commented Sep 7, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@pszafer pszafer marked this pull request as ready for review September 7, 2023 10:41
@home-assistant home-assistant bot requested a review from joostlek September 7, 2023 10:41
@joostlek joostlek added this to the 2023.9.1 milestone Sep 7, 2023
@joostlek joostlek merged commit dfee5d0 into home-assistant:dev Sep 7, 2023
teharris1 pushed a commit to teharris1/home-assistant that referenced this pull request Sep 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Epson Projector is considered "off" when in warmup state
3 participants