Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyenphase to 1.9.3 #99787

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Bump pyenphase to 1.9.3 #99787

merged 2 commits into from
Sep 7, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 7, 2023

Proposed change

changelog: pyenphase/pyenphase@v1.9.1...v1.9.3

Handle the case where the user has manually specified a password for local auth with firmware < 7.x but its incorrect (or has limited access). If they leave the password blank and chose the username installer we would generate the password for them.

The integration previously accepted any wrong password and would reduce functionality down to what works without a password. We now preserve that behavior to avoid breaking existing installs.

Also handles /production throwing a 401 even with the correct password on some 3.x firmwares.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

changelog: pyenphase/pyenphase@v1.9.1...v1.9.2

Handle the case where the user has manually specified a password for
local auth with firmware < 7.x but its incorrect.

The integration previously accepted any wrong password and would
reduce functionality down to what works without a password. We now
preserve that behavior to avoid breaking existing installs.
@home-assistant
Copy link

home-assistant bot commented Sep 7, 2023

Hey there @cgarwood, @dgomes, @joostlek, mind taking a look at this pull request as it has been labeled with an integration (enphase_envoy) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of enphase_envoy can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign enphase_envoy Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bdraco bdraco marked this pull request as draft September 7, 2023 01:42
@bdraco bdraco changed the title Bump pyenphase to 1.9.2 Bump pyenphase to 1.9.3 Sep 7, 2023
@bdraco
Copy link
Member Author

bdraco commented Sep 7, 2023

Install as custom component

cd /config
curl -o- -sSL https://gist.githubusercontent.com/bdraco/43f8043cb04b9838383fd71353e99b18/raw/core_integration_pr | bash /dev/stdin -d enphase_envoy -p 99787

@bdraco bdraco closed this Sep 7, 2023
@bdraco bdraco reopened this Sep 7, 2023
@bdraco bdraco marked this pull request as ready for review September 7, 2023 02:51
@joostlek joostlek merged commit f1ae523 into dev Sep 7, 2023
@joostlek joostlek deleted the envoy_local_auth_fix branch September 7, 2023 10:17
teharris1 pushed a commit to teharris1/home-assistant that referenced this pull request Sep 7, 2023
* Bump pyenphase to 1.9.2

changelog: pyenphase/pyenphase@v1.9.1...v1.9.2

Handle the case where the user has manually specified a password for
local auth with firmware < 7.x but its incorrect.

The integration previously accepted any wrong password and would
reduce functionality down to what works without a password. We now
preserve that behavior to avoid breaking existing installs.

* bump
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants