Bump pylutron-caseta to v0.18.2 #99789

swamplynx · 2023-09-07T02:05:38Z

Proposed change

Fixes a race with asyncio.wait_for
Adds mapping for PalladiomWireFreeShade
add support wall mounted occupancy sensor device type in latest RA3 firmware. The newer version of the dependency published to PyPi includes a minor change to the init.py to include a new device type for wall mounted occupancy sensors.

Changelog:
https://github.com/gurumitts/pylutron-caseta/blob/master/CHANGELOG.md

Diff:
gurumitts/pylutron-caseta@v0.18.1...v0.18.2

Type of change

[ x] Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

[ x] The code change is tested and works locally.
[ x] Local tests pass. Your PR cannot be merged unless tests pass
[ x] There is no commented out code in this PR.
[ x] I have followed the development checklist
[ x] I have followed the perfect PR recommendations
[ x] The code has been formatted using Black (black --fast homeassistant tests)
[ x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[x ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x ] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[ x] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[x ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
[ x] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

Minor bump to pylutron-caseta requirement to support wall mounted occupancy sensor device type in latest RA3 firmware.

home-assistant · 2023-09-07T02:05:41Z

Hi @swamplynx

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

home-assistant · 2023-09-07T02:05:45Z

Hey there @swails, @bdraco, @danaues, mind taking a look at this pull request as it has been labeled with an integration (lutron_caseta) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of lutron_caseta can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign lutron_caseta Removes the current integration label and assignees on the pull request, add the integration domain after the command.

bdraco · 2023-09-07T02:07:28Z

Thanks for bumping the dependency! Please update the PR description to contain at least one (or multiple) of the following:

A link to the release notes of this package version, and all versions in between.
A link to the changelog of this package.
A link to a Git(Hub) diff/compare view from the current version to the bumped version.
This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks 👍

bdraco

Please see above

home-assistant · 2023-09-07T02:07:44Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

bdraco · 2023-09-07T02:08:24Z

tagging for 2023.9.1 this since there is also a asyncio.wait_for race fix in the this release

swamplynx · 2023-09-07T02:18:36Z

Please see above

Updated.
Commit change view: gurumitts/pylutron-caseta@231580d

bdraco

@swamplynx please try again as your link only includes your commit, and is missing the other changes since the last release which will also be included in this bump:

We need one or more of the following:

A link to the release notes of this package version, and all versions in between.
A link to the changelog of this package.
A link to a Git(Hub) diff/compare view from the current version to the bumped version.
This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

swamplynx · 2023-09-07T02:47:02Z

@swamplynx please try again as your link only includes your commit, and is missing the other changes since the last release which will also be included in this bump:

We need one or more of the following:

A link to the release notes of this package version, and all versions in between.

A link to the changelog of this package.

A link to a Git(Hub) diff/compare view from the current version to the bumped version.
This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Sorry. Changelog linked below:
https://github.com/gurumitts/pylutron-caseta/blob/master/CHANGELOG.md

bdraco

The CI isn't passing

Please check it and address the errors:

https://github.com/home-assistant/core/actions/runs/6104548189/job/16566822821?pr=99789

bdraco · 2023-09-07T03:18:16Z

Thanks @swamplynx

bdraco · 2023-09-07T04:00:21Z

Tested on all 3 of my systems 👍

Anto79-ops · 2023-09-07T16:52:24Z

hey will this address the Caseta errors in my logs that I get about 60% of time only at startups, for example, below. The integration always works, just startups dump these logs (so I never really submitted an issue for it).

2023-09-02 17:34:10.715 WARNING (MainThread) [homeassistant.config_entries] Config entry 'Lutron' for lutron_caseta integration not ready yet: Timed out while trying to connect to 192.168.1.107; Retrying in background

2023-09-02 17:34:10.743 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/pylutron_caseta/smartbridge.py", line 709, in _login
    await self._subscribe_to_button_status()
  File "/usr/local/lib/python3.11/site-packages/pylutron_caseta/smartbridge.py", line 1244, in _subscribe_to_button_status
    response, _ = await self._subscribe(
                  ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pylutron_caseta/smartbridge.py", line 270, in _subscribe
    raise BridgeDisconnectedError()
pylutron_caseta.BridgeDisconnectedError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/pylutron_caseta/smartbridge.py", line 724, in _login
    self._login_completed.set_exception(ex)
asyncio.exceptions.InvalidStateError: invalid state

Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/pylutron_caseta/smartbridge.py", line 709, in _login
    await self._subscribe_to_button_status()
  File "/usr/local/lib/python3.11/site-packages/pylutron_caseta/smartbridge.py", line 1244, in _subscribe_to_button_status
    response, _ = await self._subscribe(
                  ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pylutron_caseta/smartbridge.py", line 270, in _subscribe
    raise BridgeDisconnectedError()
pylutron_caseta.BridgeDisconnectedError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/pylutron_caseta/smartbridge.py", line 724, in _login
    self._login_completed.set_exception(ex)
asyncio.exceptions.InvalidStateError: invalid state

bdraco · 2023-09-07T16:59:13Z

hey will this address the Caseta errors in my logs that I get about 60% of time only at startups, for example, below. The integration always works, just startups dump these logs (so I never really submitted an issue for it).

2023-09-02 17:34:10.715 WARNING (MainThread) [homeassistant.config_entries] Config entry 'Lutron' for lutron_caseta integration not ready yet: Timed out while trying to connect to 192.168.1.107; Retrying in background


2023-09-02 17:34:10.743 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved

Traceback (most recent call last):

  File "/usr/local/lib/python3.11/site-packages/pylutron_caseta/smartbridge.py", line 709, in _login

    await self._subscribe_to_button_status()

  File "/usr/local/lib/python3.11/site-packages/pylutron_caseta/smartbridge.py", line 1244, in _subscribe_to_button_status

    response, _ = await self._subscribe(

                  ^^^^^^^^^^^^^^^^^^^^^^

  File "/usr/local/lib/python3.11/site-packages/pylutron_caseta/smartbridge.py", line 270, in _subscribe

    raise BridgeDisconnectedError()

pylutron_caseta.BridgeDisconnectedError



During handling of the above exception, another exception occurred:



Traceback (most recent call last):

  File "/usr/local/lib/python3.11/site-packages/pylutron_caseta/smartbridge.py", line 724, in _login

    self._login_completed.set_exception(ex)

asyncio.exceptions.InvalidStateError: invalid state


Traceback (most recent call last):

  File "/usr/local/lib/python3.11/site-packages/pylutron_caseta/smartbridge.py", line 709, in _login

    await self._subscribe_to_button_status()

  File "/usr/local/lib/python3.11/site-packages/pylutron_caseta/smartbridge.py", line 1244, in _subscribe_to_button_status

    response, _ = await self._subscribe(

                  ^^^^^^^^^^^^^^^^^^^^^^

  File "/usr/local/lib/python3.11/site-packages/pylutron_caseta/smartbridge.py", line 270, in _subscribe

    raise BridgeDisconnectedError()

pylutron_caseta.BridgeDisconnectedError



During handling of the above exception, another exception occurred:



Traceback (most recent call last):

  File "/usr/local/lib/python3.11/site-packages/pylutron_caseta/smartbridge.py", line 724, in _login

    self._login_completed.set_exception(ex)

asyncio.exceptions.InvalidStateError: invalid state

No idea. Only way to know is try it.

* Bump pylutron-caseta to v0.18.2 Minor bump to pylutron-caseta requirement to support wall mounted occupancy sensor device type in latest RA3 firmware. * Update requirements_all.txt for pylutron-caseta 0.18.2 * Update requirements_test_all.txt for pylutron-caseta 0.18.2

Bump pylutron-caseta to v0.18.2

8e0bc33

Minor bump to pylutron-caseta requirement to support wall mounted occupancy sensor device type in latest RA3 firmware.

swamplynx requested a review from bdraco as a code owner September 7, 2023 02:05

home-assistant bot added cla-needed dependency integration: lutron_caseta small-pr PRs with less than 30 lines. labels Sep 7, 2023

home-assistant bot assigned bdraco Sep 7, 2023

home-assistant bot added the Quality Scale: No score label Sep 7, 2023

home-assistant bot added cla-recheck cla-signed and removed cla-recheck cla-needed labels Sep 7, 2023

bdraco requested changes Sep 7, 2023

View reviewed changes

home-assistant bot marked this pull request as draft September 7, 2023 02:07

bdraco added this to the 2023.9.1 milestone Sep 7, 2023

swamplynx marked this pull request as ready for review September 7, 2023 02:20

home-assistant bot requested a review from bdraco September 7, 2023 02:20

bdraco requested changes Sep 7, 2023

View reviewed changes

home-assistant bot marked this pull request as draft September 7, 2023 02:34

swamplynx marked this pull request as ready for review September 7, 2023 02:48

home-assistant bot requested a review from bdraco September 7, 2023 02:48

bdraco requested changes Sep 7, 2023

View reviewed changes

home-assistant bot marked this pull request as draft September 7, 2023 02:49

swamplynx added 2 commits September 6, 2023 23:11

Update requirements_all.txt for pylutron-caseta 0.18.2

d7a7271

Update requirements_test_all.txt for pylutron-caseta 0.18.2

9ec9554

bdraco approved these changes Sep 7, 2023

View reviewed changes

bdraco marked this pull request as ready for review September 7, 2023 03:18

home-assistant bot requested a review from bdraco September 7, 2023 03:18

joostlek merged commit e8dfa7e into home-assistant:dev Sep 7, 2023
34 checks passed

github-actions bot locked and limited conversation to collaborators Sep 8, 2023

bramkragten added the cherry-picked label Sep 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump pylutron-caseta to v0.18.2 #99789

Bump pylutron-caseta to v0.18.2 #99789

swamplynx commented Sep 7, 2023 •

edited by bdraco

home-assistant bot commented Sep 7, 2023

home-assistant bot commented Sep 7, 2023

bdraco commented Sep 7, 2023

bdraco left a comment

home-assistant bot commented Sep 7, 2023

bdraco commented Sep 7, 2023 •

edited

swamplynx commented Sep 7, 2023

bdraco left a comment

swamplynx commented Sep 7, 2023

bdraco left a comment

bdraco commented Sep 7, 2023

bdraco commented Sep 7, 2023

Anto79-ops commented Sep 7, 2023 •

edited

bdraco commented Sep 7, 2023

Bump pylutron-caseta to v0.18.2 #99789

Bump pylutron-caseta to v0.18.2 #99789

Conversation

swamplynx commented Sep 7, 2023 • edited by bdraco

Proposed change

Type of change

Additional information

Checklist

home-assistant bot commented Sep 7, 2023

home-assistant bot commented Sep 7, 2023

bdraco commented Sep 7, 2023

bdraco left a comment

Choose a reason for hiding this comment

home-assistant bot commented Sep 7, 2023

bdraco commented Sep 7, 2023 • edited

swamplynx commented Sep 7, 2023

bdraco left a comment

Choose a reason for hiding this comment

swamplynx commented Sep 7, 2023

bdraco left a comment

Choose a reason for hiding this comment

bdraco commented Sep 7, 2023

bdraco commented Sep 7, 2023

Anto79-ops commented Sep 7, 2023 • edited

bdraco commented Sep 7, 2023

swamplynx commented Sep 7, 2023 •

edited by bdraco

bdraco commented Sep 7, 2023 •

edited

Anto79-ops commented Sep 7, 2023 •

edited