Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump hatasmota to 0.7.1 #99818

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Bump hatasmota to 0.7.1 #99818

merged 1 commit into from
Sep 8, 2023

Conversation

emontnemery
Copy link
Contributor

Proposed change

Bump hatasmota to 0.7.1

Release notes: https://github.com/emontnemery/hatasmota/releases/tag/0.7.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@joostlek
Copy link
Member

joostlek commented Sep 7, 2023

Euh, doesn't this mess with HA pinning pydantic to 1. something?

@bramkragten
Copy link
Member

Euh, doesn't this mess with HA pinning pydantic to 1. something?

This you mean?

# Require to avoid issues with decorators (#93904). v2 has breaking changes.

@joostlek
Copy link
Member

joostlek commented Sep 8, 2023

Yes 😬. I did not see any code changes that enabled this lib to use the pydantic v2 features. But I'm just not 100% sure if the lib likes that it's built with v1 as that's against its selector.

@bramkragten bramkragten merged commit b317e04 into dev Sep 8, 2023
@bramkragten bramkragten deleted the bump_hatasmota_0.7.1 branch September 8, 2023 19:01
bramkragten pushed a commit that referenced this pull request Sep 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2023
@emontnemery
Copy link
Contributor Author

hatasmota uses pydantic in tests, it's setup only requires voluptuous: https://github.com/emontnemery/hatasmota/blob/100e99c399862d2f5a700352326f1c54e37630be/setup.py#L20

@joostlek
Copy link
Member

👍 that's right. So no problem here :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants