Do not inject Intl polyfill into ecma402-abstract package #21074
Conversation
WalkthroughWalkthroughThe recent update to the Changes
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional context usedPath-based instructions (1)
Biome
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range comments (2)
build-scripts/bundle.cjs (2)
Line range hint
1-1: Use thenode:protocol for importing Node.js built-in modules.- const path = require("path"); + const path = require("node:path");
Line range hint
216-216: Use template literals instead of string concatenation for better readability and performance.- const ref = env.version().endsWith("dev") ? process.env.GITHUB_SHA || "dev" : env.version(); + const ref = env.version().endsWith("dev") ? `${process.env.GITHUB_SHA || "dev"}` : `${env.version()}`; - const name = "frontend" + nameSuffix(latestBuild); + const name = `frontend${nameSuffix(latestBuild)}`; - const name = "demo" + nameSuffix(latestBuild); + const name = `demo${nameSuffix(latestBuild)}`; - const name = "cast" + nameSuffix(latestBuild); + const name = `cast${nameSuffix(latestBuild)}`; - const name = "supervisor" + nameSuffix(latestBuild); + const name = `supervisor${nameSuffix(latestBuild)}`; - const name = "gallery" + nameSuffix(latestBuild); + const name = `gallery${nameSuffix(latestBuild)}`;Also applies to: 237-237, 267-267, 281-281, 301-301
|
2024.6.3 working in iOS 12.5.7 |
Proposed change
Fixes #21004 by also excluding the
@formatjs/ecma402-abstractpackage from injection. That package is essentially helper functions for the polyfills. This bug was introduced in #20798 (basically a clerical error on my part). The polyfill was being injected there, essentially causing a circular reference and a promise that never completed as noticed in the issue.As a note to myself and others testing these polyfills in the future, executing
delete windown.Intl.DateTimeFormat, for example, is the proper way to test so that theshouldPolyfillfunctions get fully executed. Setting toundefinedor just anif (true)is not sufficient. Also deleting more than one at a time can be important.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed:
Summary by CodeRabbit