Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposed binary_sensor group #19297

Merged
merged 2 commits into from
Sep 29, 2021
Merged

proposed binary_sensor group #19297

merged 2 commits into from
Sep 29, 2021

Conversation

brianegge
Copy link
Contributor

home-assistant/core#55365

Proposed change

Add binary sensor type which has a device_class

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@brianegge brianegge requested a review from a team as a code owner September 11, 2021 11:42
@probot-home-assistant probot-home-assistant bot added the has-parent This PR has a parent PR in a other repo label Sep 11, 2021
@probot-home-assistant probot-home-assistant bot added the next This PR goes into the next branch label Sep 11, 2021
@brianegge brianegge mentioned this pull request Sep 11, 2021
Merged
22 tasks
brianegge added a commit to brianegge/core that referenced this pull request Sep 11, 2021
@brianegge
Added tests for attributes
52ca805 
link to documentation: home-assistant/home-assistant.io#19297
emontnemery pushed a commit to home-assistant/core that referenced this pull request Sep 13, 2021
@brianegge
Add component for binary sensor groups (#55365)
e638e5b 
* Add component for binary sensor groups
home-assistant/home-assistant.io#19239

* Accidental push over prior commit

* Add test for any case

* Add unavailable attribute and tests for unique_id

* Added tests for attributes

link to documentation: home-assistant/home-assistant.io#19297
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration parent-merged The parent PR has been merged already labels Sep 21, 2021
@frenck frenck mentioned this pull request Sep 22, 2021
Closed
frenck
frenck requested changes Sep 22, 2021
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For platform-specific groups, we are currently still using platform-specific pages, for example, the light group: https://www.home-assistant.io/integrations/light.group/

We should either keep it platform-specific, or merge all other group pages into a single page as well.

I would recommend the first for now (which means this PR adjusts an incorrect page).

@frenck frenck added the in-progress This PR/Issue is currently being worked on label Sep 22, 2021
@brianegge
Copy link
Contributor Author

OK - I'm happy to split this out. The code side is change, so just need the documents to match.

frenck
frenck approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @brianegge 👍

@frenck frenck merged commit 48b4145 into home-assistant:next Sep 29, 2021
@probot-home-assistant probot-home-assistant bot removed in-progress This PR/Issue is currently being worked on parent-merged The parent PR has been merged already labels Sep 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@Adminiuga Adminiuga Awaiting requested review from Adminiuga

@balloob balloob Awaiting requested review from balloob

@bdraco bdraco Awaiting requested review from bdraco

@bieniu bieniu Awaiting requested review from bieniu

@chemelli74 chemelli74 Awaiting requested review from chemelli74

@Danielhiversen Danielhiversen Awaiting requested review from Danielhiversen

@dgomes dgomes Awaiting requested review from dgomes

@dmulcahey dmulcahey Awaiting requested review from dmulcahey

@janiversen janiversen Awaiting requested review from janiversen

@rytilahti rytilahti Awaiting requested review from rytilahti

@StevenLooman StevenLooman Awaiting requested review from StevenLooman

@syssi syssi Awaiting requested review from syssi

@thecode thecode Awaiting requested review from thecode

Assignees

@brianegge brianegge

Labels
cla-signed has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brianegge @frenck @homeassistant